Skip to content

Remove HikariCP shading and expose as transitive dependency#111

Merged
garricko merged 2 commits intomasterfrom
copilot/remove-hikari-shading
Mar 10, 2026
Merged

Remove HikariCP shading and expose as transitive dependency#111
garricko merged 2 commits intomasterfrom
copilot/remove-hikari-shading

Conversation

Copy link
Contributor

Copilot AI commented Mar 10, 2026

HikariCP was being bundled into the shaded JAR with a relocated package, hiding it from consumers and requiring them to declare it separately if needed directly.

Changes

  • Remove HikariCP from shade plugin artifactSet — no longer bundled/relocated into the output JAR
  • Drop HikariCP relocation — removes the com.zaxxer.hikarishaded.com.github.susom.database.shaded.com.zaxxer.hikari rewrite
  • Remove <optional>true</optional> from the HikariCP dependency — consumers now receive HikariCP as a standard transitive dependency via Maven dependency resolution

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • us-west1-maven.pkg.dev
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.12/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.12/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.12 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.12/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/database/database org.codehaus.plexus.classworlds.launcher.Launcher clean package -Phsqldb -Duser.timezone=America/Los_Angeles -Dhsqldb.database.url=jdbc:hsqldb:file:target/hsqldb;shutdown=true -Dhsqldb.database.user=SA -Dhsqldb.database.password= (dns block)

If you need me to access, download, or install something from one of these locations, you can either:


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: garricko <1234201+garricko@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove shading of Hikari to expose as dependency Remove HikariCP shading and expose as transitive dependency Mar 10, 2026
@garricko garricko marked this pull request as ready for review March 10, 2026 23:40
@garricko garricko merged commit 2435fda into master Mar 10, 2026
7 checks passed
@garricko garricko deleted the copilot/remove-hikari-shading branch March 10, 2026 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants