fix(auth): add configurable lock acquisition timeout to prevent deadlocks #1962
+22
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocks Replace infinite lock timeout (-1) with configurable lockAcquireTimeout option that defaults to 60 seconds. This prevents production deadlocks caused by indefinite lock waiting when concurrent browser tabs or network issues interfere with lock acquisition. - Add lockAcquireTimeout option to GoTrueClientOptions (default: 60000ms) - Replace all infinite timeout (-1) lock acquisitions with configurable timeout - Users can customize the timeout or set to negative for infinite wait (not recommended) Fixes supabase#1594
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
lockAcquireTimeoutoption toGoTrueClientOptions(default: 60000ms)Fixes #1594
Test plan
npx nx build auth-js)