Conversation
Owner
|
Looks good! Please don't include the build logs in the PR though. For those macro redefinition warnings, we can just remove the macros from modules/general.h now that they're defined by the Linux headers. |
2531cb1 to
5ab3fd7
Compare
Contributor
Author
|
Apologies, didn't notice I included the logs in the PR as well! Force pushed w/ just the 6.18 changes. Exploring addressing the redundant macro definitions, but not sure how much progress I'll be able to make on that. |
Contributor
Author
|
Okay one more force push and now done, this time to include the m68k generated bindings for consistency across ISAs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As before, generate latest Linux 6.18 kernel bindings.
During generation, I noticed the following warnings which I had seen in previous CI runs if I'm not mistaken. My development environment uses clang-19, if it helps.
Full logs attached here:
build_logs.txt