Adding new roughness boundary conditions for SST

[marcosch27]

Proposed Changes

Hello everyone,

This PR is one of two contributions resulting from my Master’s Thesis.

In this PR, I’ve added new roughness boundary conditions for the SST turbulence model, based on the approach described in this paper by Aupoix.

The attached PDF includes documentation as well as validation results for a fully turbulent flat plate test case. If needed, I can add a validation test case to the SU2 suite.

Please let me know if any modifications are needed.

Related Work

PR Checklist

• I am submitting my contribution to the develop branch.
• My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
• My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
• I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
• I have added a test case that demonstrates my contribution, if necessary.
• I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

[bigfooted]

Thanks for the contribution! Can you add the new config options to config_template.cfg and add the flat plate setup? You can add the .cfg file to this PR, and the mesh and a converged restart file to a PR for the TestCases repository.

[pcarruscag]

Add a testcase please, something of verification quality, are there known results from literature for flatplates?

[marcosch27]

Thanks for the contribution! Can you add the new config options to config_template.cfg and add the flat plate setup? You can add the .cfg file to this PR, and the mesh and a converged restart file to a PR for the TestCases repository.

Thanks for the reply. I added just one entry to select the boundary condition at the wall, which is "ROUGHSST_OPTIONS", since surface roughness is specified using the existing entry "WALL_ROUGHNESS". As shown in the document attached to the PR, the present test case is the NASA ZPG Flat Plate test case with the addition of surface roughness to verify the effects of different boundary conditions for rough walls for the SST model. I will upload the test case in a PR for the TestCases repository.

[marcosch27]

Add a testcase please, something of verification quality, are there known results from literature for flatplates?

I will add the test case, and in this paper, it is possible to find an overview of the effects of the boundary conditions for rough walls for the SST model on a fully turbulent flat plate test case, including the boundary conditions that I have implemented.

[marcosch27]

Hi @pcarruscag and @bigfooted,

As part of this pull request, I’ve a validation test case for the new roughness boundary condition in the SST model.
I’d like to open a pull request to add this test case to the su2code/TestCases repository, but I currently don’t have permission to push a new branch there.

Could you please grant me temporary access or let me know the preferred procedure for contributing this test case?
Alternatively, I can open a pull request from my fork if that’s the standard approach.

Thanks a lot for your help!

[pcarruscag]

I've invited you to the SU2 organization

[marcosch27]

Hi!

I’ve opened a pull request at su2code/TestCases#178, where I’ve uploaded the validation test case for the newly implemented boundary conditions.

The results obtained with the different boundary conditions are presented in terms of the log-law profiles and velocity shift, confirming the findings reported in the literature.

[pcarruscag]

Great, can you add regression tests to *_regression.py scripts?
You can modify regression.yaml to target your new branch with the mesh and restart files.
The configs you just add to the code repo (so this PR) because that's is easier to maintain when options change.

[pcarruscag]

Thank you for the tests, I think it's good to go after these minor comments.