fix: Remove warnings from useDeepCompareEffect #2688
+9
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ricky512227
force-pushed
the
fix/remove-warnings-useDeepCompareEffect
branch
4 times, most recently
from
0eb85b5 to
f11a686
Compare
Removes the console warnings that were showing up in dev. The hook works fine with primitives, objects, or undefined - the warnings were just annoying for valid use cases. Fixes streamich#755
Ricky512227
force-pushed
the
fix/remove-warnings-useDeepCompareEffect
branch
from
f11a686 to
f2d6a2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes console.warn statements from useDeepCompareEffect hook as requested in #755. This allows users to use the hook with dependencies that could be either undefined or an object without receiving warnings.