Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request removes the NetworkRunnable trait abstraction and replaces it with direct execute methods on command structs. The goal is to simplify the code and make control flow easier to follow.
Changes:
- Removed the
NetworkRunnabletrait definition and all its implementations - Replaced
run_against_rpc_servermethod withexecutemethod for each command - Updated all commands to pass parameters directly instead of using Option wrappers
- Updated test utilities to call
executemethods directly - Refactored two unrelated methods in container/start.rs for better readability
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| cmd/soroban-cli/src/commands/mod.rs | Removes NetworkRunnable trait definition |
| cmd/soroban-cli/src/commands/tx/simulate.rs | Converts to direct execute method, removes async_trait |
| cmd/soroban-cli/src/commands/tx/send.rs | Converts to execute method with explicit config construction |
| cmd/soroban-cli/src/commands/events.rs | Converts to execute method with explicit config construction |
| cmd/soroban-cli/src/commands/contract/upload.rs | Converts to execute with direct boolean parameters |
| cmd/soroban-cli/src/commands/contract/restore.rs | Converts to execute with direct boolean parameters |
| cmd/soroban-cli/src/commands/contract/read.rs | Converts to execute method with simplified network resolution |
| cmd/soroban-cli/src/commands/contract/invoke.rs | Converts to execute with direct parameters, changes global_args passing |
| cmd/soroban-cli/src/commands/contract/fetch.rs | Converts to execute method with explicit config construction |
| cmd/soroban-cli/src/commands/contract/extend.rs | Converts to execute with direct boolean parameters |
| cmd/soroban-cli/src/commands/contract/deploy/wasm.rs | Converts to execute, updates upload command invocation |
| cmd/soroban-cli/src/commands/contract/deploy/asset.rs | Converts to execute with direct boolean parameters |
| cmd/soroban-cli/src/commands/contract/bindings/typescript.rs | Simplifies to execute method with single quiet parameter |
| cmd/soroban-cli/src/commands/container/start.rs | Refactors helper methods to use early returns (unrelated change) |
| cmd/crates/soroban-test/tests/it/util.rs | Updates test to call execute directly |
| cmd/crates/soroban-test/tests/it/integration/util.rs | Updates test to call execute directly |
| cmd/crates/soroban-test/tests/it/integration/hello_world.rs | Updates tests to call execute directly |
| cmd/crates/soroban-test/tests/it/integration/bindings.rs | Updates tests to call execute directly |
| cmd/crates/soroban-test/src/lib.rs | Removes run_cmd_with helper, updates cmd_with_config signature |
leighmcculloch
approved these changes
Jan 23, 2026
Member
leighmcculloch
left a comment
There was a problem hiding this comment.
Couple questions but this looks good regardless 😎.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove network runnable abstraction in favor of a more direct approach.
Why
So it's easier to follow.
Known limitations
N/A