[tagCopyPaste] Fix issue where copy/paste handler could be attached multiple times. #636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on Stash. There might be relevant details there: |
DogmaDragon
added
type:plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors copy/paste event handlers to no longer be anonymous functions, so that we can detach in order to prevent them from being attached multiple times.
I'm not sure if it's some quirk of the UI itself or the plugin UI library, but the
PathElementListenerfunction was consistently triggering twice which was leading to this issue (only noticeable when copy/pasting into the control, not when clicking the copy/paste buttons).