Fix task for when there are no NVMe drives#2205
Merged
technowhizz merged 2 commits intostackhpc/2025.1from Mar 11, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly refactors an Ansible task to handle cases where the nvme_devices variable may not be defined. The change replaces a when condition with a default filter on the loop variable. This is a more robust and idiomatic approach in Ansible, ensuring the task is gracefully skipped when there are no NVMe drives. The implementation is sound and I have no further suggestions.
Alex-Welsh
approved these changes
Mar 11, 2026
Member
Alex-Welsh
left a comment
Alex-Welsh
left a comment
There was a problem hiding this comment.
The release note should technically be wrapped at 80 chars, but there's a bunch that don't follow the rule so I'm happy to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.