Update msteams webhook URLs to use mandatory secrets

[jovial]

Current default never makes sense.

[Alex-Welsh]

LGTM
One suggestion but it's fine if you want to ignore it. I'm happy to merge as is

[Alex-Welsh]

nit: it'd be nice to also include a message here to make it clear what the variable is and how to acquire one

Suggested change

	- webhook_url: '{{ secrets_msteams_notification_channel_url | ansible.builtin.mandatory }}'
	- webhook_url: "{{ secrets_msteams_notification_channel_url | ansible.builtin.mandatory(msg='secrets_msteams_notification_channel_url must be defined when xyz is enabled and can be found by looking in foo place.' }}"

[jovial]

Granted that is better than the standard:

fatal: [localhost]: FAILED! => {"msg": "Mandatory variable 'secrets_msteams_notification_channel_url'  not defined."}

[gemini-code-assist]

Code Review

This pull request updates an example configuration file for Prometheus Alertmanager. The change replaces default, non-functional webhook URLs for Microsoft Teams notifications with a requirement that these URLs be provided as mandatory secrets. This is a good practice as it ensures users configure their specific endpoints, improving the robustness and security of the setup. The change is correct and well-implemented using Ansible's mandatory filter. I have no issues to report.

[jovial]

Darn, it looks like kayobe is copying the example file so needs the variable defined. I will try and prevent that, but probably explains why there was a default 😆

An exception occurred during task execution. To see the full traceback, use -vvv. The error was: ansible.errors.AnsibleFilterError: secrets_msteams_notification_channel_url is undefined. Please add this variable to secrets.yml when using the Microsoft Teams Alertmanager integration.
failed: [localhost] (item={'src': '/stack/kayobe-automation-env/src/kayobe-config/etc/kayobe/kolla/config/prometheus/prometheus-alertmanager.msteamsv2.yml.example', 'dest': '/stack/kayobe-automation-env/src/kayobe-config/etc/kolla/config/prometheus/prometheus-alertmanager.msteamsv2.yml.example', 'params': []}) => 
    ansible_loop_var: item
    changed: false
    item:
        dest: /stack/kayobe-automation-env/src/kayobe-config/etc/kolla/config/prometheus/prometheus-alertmanager.msteamsv2.yml.example
        params: []
        src: /stack/kayobe-automation-env/src/kayobe-config/etc/kayobe/kolla/config/prometheus/prometheus-alertmanager.msteamsv2.yml.example
    msg: 'AnsibleFilterError: secrets_msteams_notification_channel_url is undefined. Please
        add this variable to secrets.yml when using the Microsoft Teams Alertmanager integration.'