Conversation
danielkov
approved these changes
Mar 6, 2026
…calls Each call to esbuild.Transform() internally creates a new stderr logger that unconditionally calls GetTerminalInfo/IoctlGetTermios to check if stderr is a TTY. Since vm.compile() is called hundreds of times during generation (once per template rendered plus setup calls), and many calls receive the same source string, this accumulates significant CPU overhead. Cache esbuild.TransformResult per VM instance keyed by (name, src) to avoid redundant transform calls. The cache is bounded by the number of unique template sources and requires no eviction or synchronization since VMs are single-goroutine, where the number of template sources is not likely to be a concern in practice.
bflad
force-pushed
the
bflad/gen-2690-esbuild-getterminalinfo-syscalls-waste-4s-on-repeated-tty
branch
from
0ff78a4 to
b121a5d
Compare
Member
Author
|
Added RWMutex and rebased with main. 👍 |
bflad
deleted the
bflad/gen-2690-esbuild-getterminalinfo-syscalls-waste-4s-on-repeated-tty
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
esbuild.TransformResultper VM instance to avoid redundantesbuild.Transform()calls invm.compile()esbuild.Transform()internally callsGetTerminalInfo/IoctlGetTermiosto check if stderr is a TTY, which accumulates significant CPU overhead when called hundreds of times during generation(name, src)using a struct key and requires no eviction or synchronization since VMs are single-goroutine