Open
Conversation
grod220
force-pushed
the
list-view-migration-pt2
branch
from
45e5aa7 to
7e950e2
Compare
grod220
commented
Feb 25, 2026
Comment on lines
+3
to
+8
| /// Marker trait for converting to/from Pod `uint`'s and `usize` | ||
| pub trait PodLength: Pod + TryFrom<usize, Error = TryFromIntError> + Into<usize> {} | ||
|
|
||
| /// Blanket implementation to automatically implement `PodLength` for any type | ||
| /// that satisfies the required bounds. | ||
| impl<T> PodLength for T where T: Pod + TryFrom<usize, Error = TryFromIntError> + Into<usize> {} |
Member
Author
There was a problem hiding this comment.
Migrated from pod/src/pod_length.rs
grod220
commented
Feb 25, 2026
| macro_rules! impl_usize_conversion { | ||
| ($PodType:ty, $PrimitiveType:ty) => { | ||
| impl TryFrom<usize> for $PodType { | ||
| type Error = core::num::TryFromIntError; |
Member
Author
There was a problem hiding this comment.
Formerly was type Error = PodSliceError here. Moved to core err instead for this trait now that errors have been moved to spl-list-view.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #178
Found additional items that can be deleted/moved: