pod!: Remove OptionalNonZeroElGamalPubkey#171
Merged
samkim-crypto merged 3 commits intosolana-program:mainfrom Feb 25, 2026
Merged
pod!: Remove OptionalNonZeroElGamalPubkey#171samkim-crypto merged 3 commits intosolana-program:mainfrom
OptionalNonZeroElGamalPubkey#171samkim-crypto merged 3 commits intosolana-program:mainfrom
Conversation
Member
|
Given the upcoming breaking change, think we can just remove this entirely and not have the deprecation warning. |
samkim-crypto
force-pushed
the
deprecate-zk-sdk
branch
5 times, most recently
from
c9e4f7e to
bb2b15f
Compare
samkim-crypto
changed the title
OptionalNonZeroElGamalPubkeyOptionalNonZeroElGamalPubkey
grod220
changed the title
OptionalNonZeroElGamalPubkeyOptionalNonZeroElGamalPubkey
Member
|
Sorry, just merged a few things, given the approval dismissals---can you rebase first? Also changed the title to have the |
samkim-crypto
force-pushed
the
deprecate-zk-sdk
branch
from
bb2b15f to
18bdf7f
Compare
grod220
reviewed
Feb 25, 2026
| num_enum = "0.7" | ||
| num-traits = "0.2" | ||
| serde = { version = "1.0.228", optional = true } | ||
| serde = { version = "1.0.228", optional = true, features = ["derive"] } |
Member
There was a problem hiding this comment.
I'm guessing that the solana-zk-sdk pulled this in automatically before?
Contributor
Author
There was a problem hiding this comment.
Yes zk-sdk pulled in derive feature automatically.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
spl-podcrate depends on thesolana-zk-sdkand all of its heavy cryptographic dependencies even though it does not contain any cryptographic code. This is becausespl-podsupportsOptionalNonZeroElGamalPubkey. It would be better ifOptionalNonZeroElGamalPubkeyis moved directly into thesolana-zk-sdkso thatspl-podcan remove the dependency onsolana-zk-sdk.Summary of Changes
Remove
OptionalNonZeroElGamalPubkey.