Open
Conversation
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
had a problem deploying
to
integration
GitHub Actions
Failure
📊 API Diff Results
|
DylanTinianov
changed the title
DylanTinianov
changed the title
DylanTinianov
changed the title
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
prashantkumar1982
previously approved these changes
Mar 17, 2026
Contributor
prashantkumar1982
left a comment
prashantkumar1982
left a comment
There was a problem hiding this comment.
Sorry, didn't mean to approve before the unit-tests.
Plz add a unit-test for the empty ObservedDonTimes entry.
…common into dontime_pruning
…/chainlink-common into dontime-plugin-fixes
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
requested a deployment
to
integration
GitHub Actions
In progress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stop creating empty ObservedDonTimes entries during observation counting in Outcome. The old code inserted &pb.ObservedDonTimes{} into prevOutcome.ObservedDonTimes as a side effect of computing currSeqNum, but entries that never reached quorum were left with no timestamps and never cleaned up.
Add cleanup for entries with nil/empty timestamps in the expiry loop, so any pre-existing orphaned entries are purged on the first round after deployment.
Context
Empty ObservedDonTimes entries accumulated indefinitely because the expiry logic required len(Timestamps) > 0. Since the outcome is the OCR report transmitted by every node every round, this caused unbounded growth in P2P traffic and progressively slower OCR rounds.