Update confidential relay protocol types for remote-only secret fetching#1903
Open
Update confidential relay protocol types for remote-only secret fetching#1903
Conversation
|
👋 nadahalli, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the confidential relay protocol request type so the relay DON handler can include workflow ownership and execution metadata when building a vault secrets.get request.
Changes:
- Extend
SecretsRequestParamswithWorkflowOwner. - Extend
SecretsRequestParamswithWorkflowExecutionID.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| Attestation string `json:"attestation,omitempty"` | ||
| WorkflowID string `json:"workflow_id"` | ||
| WorkflowOwner string `json:"workflow_owner"` | ||
| WorkflowExecutionID string `json:"workflow_execution_id"` |
nadahalli
force-pushed
the
tejaswi/relay-secrets-params
branch
from
6ca4d25 to
acb562e
Compare
nadahalli
changed the title
…ublicKey/Threshold from response SecretsRequestParams: added WorkflowOwner and WorkflowExecutionID. The relay DON handler needs these to build a valid vault secrets.get request (owner matching, execution ID validation). SecretsResponseResult: removed MasterPublicKey and Threshold. The enclave uses its own config for both (EnclaveConfig.MasterPublicKey and EnclaveConfig.T from on-chain DON config, populated after DKG). The relay handler is a pass-through for encrypted shares only.
nadahalli
force-pushed
the
tejaswi/relay-secrets-params
branch
from
acb562e to
f480e53
Compare
pavel-raykov
approved these changes
Mar 17, 2026
DylanTinianov
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WorkflowOwnerandWorkflowExecutionIDtoSecretsRequestParams. The relay DON handler needs these to build a valid vaultsecrets.getrequest (owner matching and execution ID validation).MasterPublicKeyandThresholdfromSecretsResponseResult. The enclave has both from its own config (EnclaveConfig.MasterPublicKeyandEnclaveConfig.T, populated from on-chain DON config after DKG). The relay handler is a pass-through for encrypted shares only.Part of the remote-only secret fetching work where the enclave fetches secrets dynamically at runtime via enclave -> gateway -> relay DON -> VaultDON, instead of the executor prefetching them before dispatch.