Direct send if retransmit disabled#1897
Merged
DylanTinianov merged 4 commits intomainfrom Mar 16, 2026
Merged
Conversation
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
📊 API Diff Results
|
bolekk
reviewed
Mar 16, 2026
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
bolekk
previously approved these changes
Mar 16, 2026
pkg/capabilities/base_trigger.go
Outdated
| } | ||
|
|
||
| b.lggr.Infof("event dispatched: capability =%s trigger=%s event=%s attempt=%d", | ||
| b.lggr.Infof("event dispatched: capability=%s trigger=%s event=%s attempt=%d", |
Contributor
There was a problem hiding this comment.
should this log be inside sendToInbox() new?
Contributor
There was a problem hiding this comment.
Yes, moving it under sendToInbox() will ensure this log gets logged when called from DeliverEvent()
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
fernandezlautaro
approved these changes
Mar 16, 2026
prashantkumar1982
approved these changes
Mar 16, 2026
bolekk
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disables retransmitting trigger events if retransmit interval is set to 0.