feat: add ExpectedSimulationFailureRule to ContractWriter.SubmitTransaction

[Fletch153]

Summary

• Adds ExpectedSimulationFailureRule struct (ErrorContains string) to pkg/types/ and a new []ExpectedSimulationFailureRule parameter to ContractWriter.SubmitTransaction
• Adds corresponding proto messages to contract_writer.proto (field 8) and aptos.proto (field 4) with regenerated Go code
• Wires gRPC client/server via FailureRulesToProto/FailureRulesFromProto converter functions, following the existing TxMeta pattern
• Adds UnimplementedContractWriter forward-compat base type
• Updates all in-repo call sites and test fakes

Breaking Change

ContractWriter.SubmitTransaction signature now requires an additional []ExpectedSimulationFailureRule parameter. All implementations must update their signatures. Pass nil to preserve existing behavior.

Context

chainlink-aptos (NONEVM-2618) added ExpectedSimulationFailureRule to its TXM Enqueue, but SubmitTransaction (the product-agnostic interface in chainlink-common) didn't carry these rules. This change enables failure rules to flow from callers through the LOOP gRPC boundary to chain-specific implementations.

Test plan

• Converter round-trip tests (nil, empty, populated) for both directions
• go build ./... passes
• go test ./... passes (pre-existing otelzap failure unrelated)
• CI pipeline (lint, tests, gorelease API diff)

[github-actions]

👋 Fletch153, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

[github-actions]

⚠️ API Diff Results - github.com/smartcontractkit/chainlink-common

⚠️ Breaking Changes (3)

pkg/capabilities/pb.(*InitialiseRequest) (1)

• GetTriggerEventStoreId — 🗑️ Removed

pkg/capabilities/pb.InitialiseRequest (1)

• TriggerEventStoreId — 🗑️ Removed

pkg/types.ContractWriter (1)

• SubmitTransaction — Type changed:

func(
  context.Context, 
  string, 
  string, 
  any, 
  IdempotencyKey, 
  string, 
  *TxMeta, 
  *math/big.Int, 
  + *SimulationOptions
)
error

✅ Compatible Changes (9)

pkg/chains/aptos (2)

• ExpectedSimulationFailureError — ➕ Added

• SimulationOptions — ➕ Added

pkg/chains/aptos.(*SubmitTransactionRequest) (1)

• GetSimulationOptions — ➕ Added

pkg/chains/aptos.SubmitTransactionRequest (1)

• SimulationOptions — ➕ Added

pkg/types (2)

• ExpectedSimulationFailureError — ➕ Added

• SimulationOptions — ➕ Added

pkg/types/chains/aptos (2)

• ExpectedSimulationFailureError — ➕ Added

• SimulationOptions — ➕ Added

pkg/types/chains/aptos.SubmitTransactionRequest (1)

• SimulationOptions — ➕ Added

---

📄 View full apidiff report

[jmank88]

You could avoid future breaking changes by switching to a single struct arg like grpc uses:

Suggested change

	func (c *Client) SubmitTransaction(ctx context.Context, contractName, method string, params any, transactionID, toAddress string, meta *types.TxMeta, value *big.Int, expectedSimulationFailureRules []types.ExpectedSimulationFailureRule) error {
	func (c *Client) SubmitTransaction(ctx context.Context, req SubmitTransactionRequest) error {

[Fletch153]

I was thinking of doing this tbh, i've done this for SimulationOptions (in a recent commit) but perhaps it's better we go with a single request argument struct as you suggested