Skip to content

[???] move keys from core#1827

Closed
pavel-raykov wants to merge 13 commits intomainfrom
move-keys
Closed

[???] move keys from core#1827
pavel-raykov wants to merge 13 commits intomainfrom
move-keys

Conversation

@pavel-raykov
Copy link
Contributor

@pavel-raykov pavel-raykov commented Feb 9, 2026

No description provided.

@github-actions
Copy link

github-actions bot commented Feb 10, 2026 •
edited
Loading

✅ API Diff Results - No breaking changes

📄 View full apidiff report

jmank88
jmank88 reviewed Feb 10, 2026
View reviewed changes
pkg/chains/types/type.go
)

// ChainType denotes the chain or network to work with
type ChainType string
Copy link
Contributor

@jmank88 jmank88 Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we already have a version of this? Typically "family" or "network". If not in this repo, then how about chain selectors?

jmank88
jmank88 reviewed Feb 10, 2026
View reviewed changes
keystore/keystore.go
Comment on lines -128 to -138
type ScryptParams struct {
N int
P int
}

var (
DefaultScryptParams = ScryptParams{
N: gethkeystore.StandardScryptN,
P: gethkeystore.StandardScryptP,
}
FastScryptParams ScryptParams = ScryptParams{
Copy link
Contributor

@jmank88 jmank88 Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep the API compatible with aliases/assigments from the new versions

@github-actions
Copy link

github-actions bot commented Mar 13, 2026

This PR is stale because it has been open 30 days with no activity.
Remove the stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmank88 jmank88 jmank88 left review comments

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pavel-raykov @jmank88