Simplify Watson main script and trying to make it more POSIXy#25
Open
pablojimpas wants to merge 5 commits intosmall-tech:mainfrom
Open
Simplify Watson main script and trying to make it more POSIXy#25pablojimpas wants to merge 5 commits intosmall-tech:mainfrom
pablojimpas wants to merge 5 commits intosmall-tech:mainfrom
Conversation
Based on shellcheck.net rules and with the help of https://github.com/dylanaraps/pure-sh-bible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was recently learning some syntax differences between POSIX
shandbashwhile reading pure-sh-bible and pure-bash-bible.So I thought it will be great to put some things in practice contributing to Watson.
It's an initial work in progress to get the script fully POSIX compliant but I already consider some of the syntax changes an improvement.
I'm also using https://github.com/koalaman/shellcheck to fix some things along the way.
I hope to make more meaningful contributions to Comet but this is my humble start for now, keep up the great work!