Skip to content

Conversation

@waleedlatif1
Copy link
Collaborator

Summary

  • Add branding ConfigMap to inject custom logos, CSS, and binary assets into the app
  • Auto-mounts to /app/public/branding when enabled
  • Supports both text files (files) and binary files (binaryFiles) via base64

Type of Change

  • New feature

Testing

Tested with helm template and helm lint - both pass

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link

vercel bot commented Jan 26, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
docs Ready Ready Preview, Comment Jan 26, 2026 9:09pm

Request Review

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 26, 2026

Greptile Overview

Greptile Summary

This PR adds a branding ConfigMap feature that enables users to inject custom logos, CSS, and other assets into the Sim application. The implementation follows established Helm patterns from the codebase and provides a clean interface for mounting both text and binary files.

Key Changes:

  • New configmap-branding.yaml template creates a ConfigMap with data (text files) and binaryData (base64-encoded binaries)
  • Modified deployment-app.yaml to conditionally mount the branding ConfigMap as a read-only volume at /app/public/branding
  • Added branding configuration section in values.yaml with clear examples and documentation for text and binary files
  • Volume mounting logic matches existing patterns (e.g., ollama persistence implementation)
  • All changes are gated behind branding.enabled flag (defaults to false)

Implementation Quality:

  • Follows existing Helm template patterns consistently
  • Proper use of conditionals for optional features
  • Clear documentation with examples in values.yaml
  • Read-only mount ensures security best practices

Confidence Score: 5/5

  • This PR is safe to merge with no blocking issues
  • The implementation is clean, follows established patterns in the codebase, and introduces no breaking changes. The feature is opt-in (disabled by default), properly documented, and uses read-only mounts for security. The code has been tested with helm template and helm lint as stated in the PR description.
  • No files require special attention

Important Files Changed

Filename Overview
helm/sim/templates/configmap-branding.yaml New ConfigMap template for branding assets with text and binary file support
helm/sim/templates/deployment-app.yaml Added conditional volume and volumeMount for branding ConfigMap to app deployment
helm/sim/values.yaml Added branding configuration section with files, binaryFiles, and mountPath options

Sequence Diagram

sequenceDiagram
    participant User as Helm User
    participant Values as values.yaml
    participant CM as ConfigMap Template
    participant Deploy as Deployment Template
    participant K8s as Kubernetes
    participant App as App Container

    User->>Values: Set branding.enabled=true
    User->>Values: Define branding.files & binaryFiles
    User->>Values: Set branding.mountPath (optional)
    
    alt branding.enabled == true
        CM->>K8s: Create ConfigMap with data/binaryData
        Deploy->>K8s: Add branding volume to Deployment
        Deploy->>K8s: Add branding volumeMount to container
        K8s->>App: Mount ConfigMap at /app/public/branding
        App->>App: Branding assets available in public directory
    else branding.enabled == false
        CM-->>K8s: ConfigMap not created
        Deploy-->>K8s: No branding volume added
    end
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@waleedlatif1 waleedlatif1 merged commit d8d85fc into staging Jan 26, 2026
11 checks passed
@waleedlatif1 waleedlatif1 deleted the improvement/helm branch January 26, 2026 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants