-
Notifications
You must be signed in to change notification settings - Fork 3.3k
fix(docs): separate local and blob asset resolution for quick-reference #3007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ActionImage now uses local paths directly for PNGs while ActionVideo uses blob storage with proper path normalization (strips static/ prefix). Co-Authored-By: Claude Opus 4.5 <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile OverviewGreptile SummaryThis PR fixes 404 errors by separating asset resolution paths for images and videos in the quick-reference documentation. PNG images now load directly from the local Key Changes:
Observations:
Confidence Score: 4/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant MDX as Quick Reference MDX
participant AI as ActionImage Component
participant AV as ActionVideo Component
participant NBP as normalizeBlobPath
participant GAU as getAssetUrl
participant Static as /static/ Directory
participant Blob as Vercel Blob Storage
Note over MDX: PNG Image Request
MDX->>AI: src="/static/quick-reference/image.png"
AI->>AI: Ensure leading slash
AI->>Static: /static/quick-reference/image.png
Static-->>MDX: PNG served locally
Note over MDX: MP4 Video Request
MDX->>AV: src="/static/quick-reference/video.mp4"
AV->>NBP: "/static/quick-reference/video.mp4"
NBP->>NBP: Strip leading "/"
NBP->>NBP: Strip "static/" prefix
NBP-->>AV: "quick-reference/video.mp4"
AV->>GAU: "quick-reference/video.mp4"
alt CDN Configured
GAU-->>AV: ${CDN}/quick-reference/video.mp4
else No CDN
GAU-->>AV: /quick-reference/video.mp4
end
AV->>Blob: Request video from blob storage
Blob-->>MDX: MP4 streamed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No files reviewed, no comments
…ctly Remove path normalization logic from action-media component. Instead, use the appropriate paths in MDX: - PNGs: /static/quick-reference/... (local) - MP4s: quick-reference/... (blob via getAssetUrl)
9a1dfb8 to
b04f8ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Summary
/static/)static/prefixTest plan
/static/quick-reference/path