CalibratedSensor: Allow calibration with provided lut#83
Open
schnili wants to merge 1 commit intosimplefoc:devfrom
Open
CalibratedSensor: Allow calibration with provided lut#83schnili wants to merge 1 commit intosimplefoc:devfrom
schnili wants to merge 1 commit intosimplefoc:devfrom
Conversation
If a lut was provided the calibration was simply skipped. If you do not provide a lut it gets allocated but you cant extract the data at runntime (only via printLUT).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I think i found a logic error. The return in calibrate prevents providing a lut and writing to it and since the allocated lut is protected in the class there is no way to extract at runtime.
The README:150 already suggests not calling calibrate when you provide a valid lut.
...and sry for not updating the README.md correctly last PR :/