refactor!: v3.0.0 major overhaul #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Hook: stabilize useCodeExecution (refs, stable execute, updateCode alias) - Tests: fix TypeScript matchers and marked renderer signature; remove unused vars - Docs: README requirements, hook example, CI/CD notes - CI: Node 18 + PNPM, cache; turbo scripts; gh-pages publish docs/dist - Publish: Changesets + npm provenance (OIDC), remove NODE_AUTH_TOKEN - Misc: align workspace configs
…n and Node/PNPM requirements
There was a problem hiding this comment.
Pull request overview
This PR introduces a major v3.0.0 refactor that modernizes the React Code View project by migrating to a PNPM monorepo structure, updating build tooling to use modern solutions (Vite, Turbo, tsup), replacing highlight.js with Shiki for syntax highlighting, and upgrading from CodeMirror 5 to CodeMirror 6. The changes include comprehensive documentation, migration guides, and support for multiple build tools through unplugin.
Key Changes
- Migrated from single package to PNPM monorepo with 4 packages:
@react-code-view/core,@react-code-view/react,@react-code-view/unplugin, andreact-code-view - Replaced legacy webpack-md-loader with universal unplugin supporting Webpack, Vite, Rollup, esbuild, and Rspack
- Modernized syntax highlighting by switching from highlight.js to Shiki, and editor from CodeMirror 5 to CodeMirror 6
- Updated minimum Node version to 18+ and added comprehensive TypeScript project references
Reviewed changes
Copilot reviewed 172 out of 179 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| package.json | Root package.json converted to monorepo configuration with PNPM and Turbo |
| pnpm-workspace.yaml | Workspace configuration for packages and examples |
| turbo.json | Turbo build orchestration configuration |
| tsconfig.json, tsconfig.base.json | TypeScript project references for monorepo |
| vite.config.ts | Vite configuration for documentation site |
| packages/core/* | New core package with Shiki-based markdown transformation |
| packages/react/* | React components with CodeMirror 6 and updated architecture |
| packages/unplugin/* | Universal build tool plugin package |
| packages/react-code-view/* | Main package re-exporting from other packages |
| examples/* | Example projects for Vite, Webpack, Rollup, and esbuild |
| webpack-md-loader/* | Removed legacy webpack loader |
| src/* | Removed old source files (migrated to packages/) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| export const OverviewPage: React.FC<OverviewPageProps> = ({ theme }) => { | ||
| const isDark = theme === 'rcv-theme-dark'; | ||
| const codeTheme = isDark ? 'github-dark' : 'github-light'; |
There was a problem hiding this comment.
Unused variable codeTheme.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a major v3.0.0 refactor and modernization of the React Code View project, reorganizing the codebase into a PNPM monorepo, updating CI/CD workflows, enforcing consistent linting and formatting, and providing comprehensive documentation and migration guidance. The update brings breaking changes to package structure, build tool integration, and minimum requirements, while improving developer experience and maintainability.
Major v3.0.0 Refactor and Monorepo Migration:
README.mdto provide clear installation, usage, migration, and contribution instructions, reflecting the new package structure and build tool support.Monorepo and Tooling Modernization:
docs/dist. [1] [2] [3]Breaking Changes and Cleanup:
CodeEditor,CodeView, andErrorBoundary, reflecting the new architecture and test approach. [1] [2] [3]See the included migration guide in the README and changeset for full details on breaking changes and how to upgrade.