Skip to content

Conversation

@RobbieTheWagner
Copy link
Member

@RobbieTheWagner RobbieTheWagner commented Jan 13, 2026

Summary by CodeRabbit

  • Chores
    • Bumped ember-inputmask dependency to ^4.0.1.
    • Updated input mask usage to import from the package's public module paths for consistency.
    • Removed the OneWayInputMask entry from the public Glint/typings registry (type declaration surface reduced).

✏️ Tip: You can customize this high-level summary in your review settings.

@RobbieTheWagner RobbieTheWagner added the enhancement New feature or request label Jan 13, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 13, 2026

📝 Walkthrough

Walkthrough

Upgrades ember-inputmask from ^3.0.1 to ^4.0.1, removes the OneWayInputMask Glint registry declaration, narrows Glint imports, and updates three components to import OneWayInputMask from the public ember-inputmask/components/one-way-input-mask path.

Changes

Cohort / File(s) Summary
Dependency upgrade
package.json
ember-inputmask updated from ^3.0.1 to ^4.0.1
Type declarations cleanup
types/global.d.ts
Removed OneWayInputMask public declaration from @glint/environment-ember-loose/registry; narrowed imports from @glint/template (dropped ComponentLike, HelperLike)
Component import updates
app/components/*
\app/components/alpha-input.gts`, `app/components/hex-input.gts`, `app/components/rgb-input.gts``
Replaced internal import ember-inputmask/_app_/components/one-way-input-mask.js with public ember-inputmask/components/one-way-input-mask; removed preceding ts-expect-error comments

Sequence Diagram(s)

(Skipped — changes are dependency, typings, and import-path updates without new multi-component control flow.)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰
A hop, a sniff, the version climbs high,
Masks now come public beneath the sky.
Typings pared down, imports set straight,
I twitch my nose — the patch looks great.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: updating the ember-inputmask dependency from version 3.x to 4.x, including corresponding import path updates across multiple components.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.



📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between aadd499 and 5c1806e.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • package.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Tests
  • GitHub Check: Lint

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
package.json (1)

84-84: ember-inputmask v4 usage is compatible with current code, but confirm if any custom mask/caret options are planned.

The codebase uses OneWayInputMask in three color input components (rgb-input.gts, hex-input.gts, alpha-input.gts) with basic usage patterns. The v4.0.0 breaking changes (Regex alias removal, greedy default changes, androidHack → disablePredictiveText, positionCaretOnClick behavior changes) do not appear to affect the current OneWayInputMask usages.

pnpm-lock.yaml is properly tracked in git and already locked to [email protected] with [email protected]. If you're using only the default OneWayInputMask component without custom mask definitions or caret-handling, no action is needed. If future work adds custom masks or advanced Inputmask options, verify against the v4 migration guide.

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f103f59 and 655233c.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (2)
  • package.json
  • types/global.d.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Tests
🔇 Additional comments (1)
types/global.d.ts (1)

3-3: No actionable changes needed—OneWayInputMask was never in the Glint registry and remains properly imported where used.

The narrowed import of ModifierLike on line 3 is correct and unrelated to OneWayInputMask. The Glint registry in types/global.d.ts contains only 'css-transition' and 'on-click-outside' entries. OneWayInputMask is imported directly from 'ember-inputmask' in the three components that use it (rgb-input.gts, hex-input.gts, alpha-input.gts) and requires no registry entry.

@RobbieTheWagner RobbieTheWagner merged commit 89937e3 into main Jan 15, 2026
4 checks passed
@RobbieTheWagner RobbieTheWagner deleted the inputmask-4 branch January 15, 2026 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants