improve container credentials retrieval matching container repository names#278
Open
munishchouhan wants to merge 50 commits intomasterfrom
Open
Conversation
…er-credentials-retrieval-matching-container-repository-names
pditommaso
reviewed
Aug 10, 2023
src/main/groovy/io/seqera/wave/auth/RegistryAuthServiceImpl.groovy
Outdated
Show resolved
Hide resolved
…er-credentials-retrieval-matching-container-repository-names
…er-credentials-retrieval-matching-container-repository-names
…er-credentials-retrieval-matching-container-repository-names
…er-credentials-retrieval-matching-container-repository-names
…er-credentials-retrieval-matching-container-repository-names
…er-credentials-retrieval-matching-container-repository-names
…er-credentials-retrieval-matching-container-repository-names
…l-matching-container-repository-names
…l-matching-container-repository-names
…l-matching-container-repository-names
Contributor
|
@pditommaso pinging you on this one - can you provide an output on any dependency that is holding this PR? thank you :-) |
…l-matching-container-repository-names
…l-matching-container-repository-names
…l-matching-container-repository-names
…l-matching-container-repository-names
Signed-off-by: Paolo Di Tommaso <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
1a7df00 to
4fbf3bb
Compare
…l-matching-container-repository-names
…l-matching-container-repository-names
…l-matching-container-repository-names
…l-matching-container-repository-names
…l-matching-container-repository-names
…l-matching-container-repository-names
…l-matching-container-repository-names
…l-matching-container-repository-names
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 8498070 | Triggered | Username Password | f8eed91 | src/test/groovy/io/seqera/wave/auth/RegistryCredentialsProviderTest.groovy | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
…l-matching-container-repository-names
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
…l-matching-container-repository-names
…l-matching-container-repository-names
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.