Skip to content

Fix base Chromium in Driver() format #4180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdmintz merged 2 commits into from
Dec 22, 2025
+34 −30
Merged

Fix base Chromium in Driver() format #4180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca2d270
Fix base Chromium in Driver() format
mdmintz Dec 22, 2025
cc3e355
Version 4.45.5
mdmintz Dec 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion seleniumbase/__version__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
# seleniumbase package
__version__ = "4.45.4"
__version__ = "4.45.5"
62 changes: 33 additions & 29 deletions seleniumbase/core/browser_launcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3058,22 +3058,22 @@ def get_driver(
):
sb_config._ext_dirs = []
driver_dir = DRIVER_DIR
if getattr(sb_config, "binary_location", None) == "cft":
if binary_location == "_chromium_":
driver_dir = DRIVER_DIR_CHROMIUM
elif binary_location == "cft":
driver_dir = DRIVER_DIR_CFT
if getattr(sb_config, "binary_location", None) == "chs":
elif binary_location == "chs":
driver_dir = DRIVER_DIR_CHS
if getattr(sb_config, "binary_location", None) == "_chromium_":
driver_dir = DRIVER_DIR_CHROMIUM
if _special_binary_exists(binary_location, "opera"):
elif _special_binary_exists(binary_location, "opera"):
driver_dir = DRIVER_DIR_OPERA
sb_config._cdp_browser = "opera"
if _special_binary_exists(binary_location, "brave"):
elif _special_binary_exists(binary_location, "brave"):
driver_dir = DRIVER_DIR_BRAVE
sb_config._cdp_browser = "brave"
if _special_binary_exists(binary_location, "comet"):
elif _special_binary_exists(binary_location, "comet"):
driver_dir = DRIVER_DIR_COMET
sb_config._cdp_browser = "comet"
if _special_binary_exists(binary_location, "atlas"):
elif _special_binary_exists(binary_location, "atlas"):
driver_dir = DRIVER_DIR_ATLAS
sb_config._cdp_browser = "atlas"
if (
Expand Down Expand Up @@ -4099,27 +4099,31 @@ def get_local_driver(
downloads_path = DOWNLOADS_FOLDER
driver_dir = DRIVER_DIR
special_chrome = False
if getattr(sb_config, "binary_location", None) == "_chromium_":
special_chrome = True
driver_dir = DRIVER_DIR_CHROMIUM
if getattr(sb_config, "binary_location", None) == "cft":
special_chrome = True
driver_dir = DRIVER_DIR_CFT
if getattr(sb_config, "binary_location", None) == "chs":
special_chrome = True
driver_dir = DRIVER_DIR_CHS
if _special_binary_exists(binary_location, "opera"):
special_chrome = True
driver_dir = DRIVER_DIR_OPERA
if _special_binary_exists(binary_location, "brave"):
special_chrome = True
driver_dir = DRIVER_DIR_BRAVE
if _special_binary_exists(binary_location, "comet"):
special_chrome = True
driver_dir = DRIVER_DIR_COMET
if _special_binary_exists(binary_location, "atlas"):
special_chrome = True
driver_dir = DRIVER_DIR_ATLAS
if binary_location:
if (
binary_location == "_chromium_"
or "chromium_drivers" in binary_location
):
special_chrome = True
driver_dir = DRIVER_DIR_CHROMIUM
elif binary_location == "cft" or "cft_drivers" in binary_location:
special_chrome = True
driver_dir = DRIVER_DIR_CFT
elif binary_location == "chs" or "chs_drivers" in binary_location:
special_chrome = True
driver_dir = DRIVER_DIR_CHS
elif _special_binary_exists(binary_location, "opera"):
special_chrome = True
driver_dir = DRIVER_DIR_OPERA
elif _special_binary_exists(binary_location, "brave"):
special_chrome = True
driver_dir = DRIVER_DIR_BRAVE
elif _special_binary_exists(binary_location, "comet"):
special_chrome = True
driver_dir = DRIVER_DIR_COMET
elif _special_binary_exists(binary_location, "atlas"):
special_chrome = True
driver_dir = DRIVER_DIR_ATLAS
if (
hasattr(sb_config, "settings")
and getattr(sb_config.settings, "NEW_DRIVER_DIR", None)
Expand Down