Skip to content

perf(store): lazy-init sortedCache in cachekv.Store #2804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pdrobnjak wants to merge 3 commits into
base: main
Choose a base branch
from
Open

perf(store): lazy-init sortedCache in cachekv.Store #2804

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
80e8099
perf(store): lazy-init sortedCache in cachekv.Store
pdrobnjak Feb 5, 2026
fd2e28d
refactor(store): use self-initializing getter for sortedCache
pdrobnjak Feb 5, 2026
4be37df
Merge branch 'main' into perf/lazy-init-sorted-cache
pdrobnjak Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions sei-cosmos/store/cachekv/store.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ func NewStore(parent types.KVStore, storeKey types.StoreKey, cacheSize int) *Sto
cache: &sync.Map{},
deleted: &sync.Map{},
unsortedCache: &sync.Map{},
sortedCache: dbm.NewMemDB(),
sortedCache: nil,
parent: parent,
storeKey: storeKey,
cacheSize: cacheSize,
Expand Down Expand Up @@ -120,7 +120,7 @@ func (store *Store) Write() {
store.cache = &sync.Map{}
store.deleted = &sync.Map{}
store.unsortedCache = &sync.Map{}
store.sortedCache = dbm.NewMemDB()
store.sortedCache = nil
}

// CacheWrap implements CacheWrapper.
Expand All @@ -146,6 +146,13 @@ func (store *Store) ReverseIterator(start, end []byte) types.Iterator {
return store.iterator(start, end, false)
}

func (store *Store) getOrInitSortedCache() *dbm.MemDB {
if store.sortedCache == nil {
store.sortedCache = dbm.NewMemDB()
}
return store.sortedCache
}

func (store *Store) iterator(start, end []byte, ascending bool) types.Iterator {
store.mtx.Lock()
defer store.mtx.Unlock()
Expand All @@ -168,7 +175,7 @@ func (store *Store) iterator(start, end []byte, ascending bool) types.Iterator {
}
}()
store.dirtyItems(start, end)
cache = newMemIterator(start, end, store.sortedCache, store.deleted, ascending)
cache = newMemIterator(start, end, store.getOrInitSortedCache(), store.deleted, ascending)
return NewCacheMergeIterator(parent, cache, ascending, store.storeKey)
}

Expand Down Expand Up @@ -301,13 +308,13 @@ func (store *Store) clearUnsortedCacheSubset(unsorted []*kv.Pair, sortState sort
if item.Value == nil {
// deleted element, tracked by store.deleted
// setting arbitrary value
if err := store.sortedCache.Set(item.Key, []byte{}); err != nil {
if err := store.getOrInitSortedCache().Set(item.Key, []byte{}); err != nil {
panic(err)
}

continue
}
if err := store.sortedCache.Set(item.Key, item.Value); err != nil {
if err := store.getOrInitSortedCache().Set(item.Key, item.Value); err != nil {
panic(err)
}
}
Expand Down
Loading