go bench receipts parquet vs pebble#2794
Open
jewei1997 wants to merge 2 commits intoparquet-receiptdbfrom
Open
go bench receipts parquet vs pebble#2794jewei1997 wants to merge 2 commits intoparquet-receiptdbfrom
jewei1997 wants to merge 2 commits intoparquet-receiptdbfrom
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## parquet-receiptdb #2794 +/- ##
=====================================================
- Coverage 56.65% 47.08% -9.57%
=====================================================
Files 2019 1951 -68
Lines 165709 160030 -5679
=====================================================
- Hits 93880 75349 -18531
- Misses 63597 78152 +14555
+ Partials 8232 6529 -1703
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Benchmark Results
The parquet-no-wal variant (bypasses WAL for benchmarking) shows parquet's raw write performance is competitive with pebble. WAL batching improved
parquet-async throughput by ~1.5-2x compared to per-receipt WAL writes.