feat(sei-db): add flatkv store implementation by blindchaser · Pull Request #2793 · sei-protocol/sei-chain

blindchaser · 2026-02-03T19:36:57Z

Multi-DB storage: storageDB, accountDB, codeDB, metadataDB
LtHash-based state commitment using internal key formats
Configurable write toggles per DB type
Iterator support for storage keys

Describe your changes and provide context

Testing performed to validate your change

github-actions · 2026-02-03T19:37:58Z

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

Build	Format	Lint	Breaking	Updated (UTC)
`✅ passed`	`✅ passed`	`✅ passed`	`✅ passed`	Feb 3, 2026, 8:35 PM

codecov · 2026-02-03T19:39:42Z

Codecov Report

❌ Patch coverage is 58.78468% with 312 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.66%. Comparing base (4d7369c) to head (1883bfb).

Files with missing lines	Patch %	Lines
sei-db/state_db/sc/flatkv/store.go	61.74%	80 Missing and 47 partials ⚠️
sei-db/state_db/sc/flatkv/iterator.go	41.60%	61 Missing and 12 partials ⚠️
sei-db/state_db/sc/flatkv/store_read.go	56.42%	47 Missing and 14 partials ⚠️
sei-db/state_db/sc/composite/store.go	32.25%	16 Missing and 5 partials ⚠️
sei-db/state_db/sc/flatkv/store_lifecycle.go	57.14%	6 Missing and 6 partials ⚠️
sei-db/state_db/sc/flatkv/store_meta.go	67.56%	6 Missing and 6 partials ⚠️
sei-db/state_db/sc/flatkv/keys.go	84.00%	4 Missing ⚠️
sei-db/common/evm/keys.go	93.54%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2793      +/-   ##
==========================================
+ Coverage   56.65%   56.66%   +0.01%     
==========================================
  Files        2031     2036       +5     
  Lines      165854   166570     +716     
==========================================
+ Hits        93959    94382     +423     
- Misses      63664    63867     +203     
- Partials     8231     8321      +90

Flag	Coverage Δ
sei-chain	`41.59% <58.78%> (+0.08%)`	⬆️
sei-cosmos	`48.11% <ø> (ø)`
sei-db	`68.72% <ø> (ø)`
sei-tendermint	`58.03% <ø> (-0.04%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
sei-db/config/flatkv_config.go	`100.00% <100.00%> (ø)`
sei-db/config/sc_config.go	`100.00% <100.00%> (ø)`
sei-db/common/evm/keys.go	`88.46% <93.54%> (+7.50%)`	⬆️
sei-db/state_db/sc/flatkv/keys.go	`95.29% <84.00%> (+23.00%)`	⬆️
sei-db/state_db/sc/flatkv/store_lifecycle.go	`57.14% <57.14%> (ø)`
sei-db/state_db/sc/flatkv/store_meta.go	`67.56% <67.56%> (ø)`
sei-db/state_db/sc/composite/store.go	`48.64% <32.25%> (-8.20%)`	⬇️
sei-db/state_db/sc/flatkv/store_read.go	`56.42% <56.42%> (ø)`
sei-db/state_db/sc/flatkv/iterator.go	`41.60% <41.60%> (ø)`
sei-db/state_db/sc/flatkv/store.go	`61.74% <61.74%> (ø)`

... and 20 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 34a6fed4c3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

sei-db/state_db/sc/composite/store.go

sei-db/state_db/sc/flatkv/store_read.go

sei-db/state_db/sc/flatkv/store.go

+		for _, pw := range s.codeWrites {
+			if pw.isDelete {
+				if err := batch.Delete(pw.key); err != nil {
+					return fmt.Errorf("codeDB delete: %w", err)
+				}
+			} else {
+				if err := batch.Set(pw.key, pw.value); err != nil {
+					return fmt.Errorf("codeDB set: %w", err)
+				}
+			}
+		}


sei-db/state_db/sc/flatkv/store.go

+		for _, pw := range s.storageWrites {
+			if pw.isDelete {
+				if err := batch.Delete(pw.key); err != nil {
+					return fmt.Errorf("storageDB delete: %w", err)
+				}
+			} else {
+				if err := batch.Set(pw.key, pw.value); err != nil {
+					return fmt.Errorf("storageDB set: %w", err)
+				}
+			}
+		}


- Multi-DB storage: storageDB, accountDB, codeDB, metadataDB - LtHash-based state commitment using internal key formats - Configurable write toggles per DB type - Iterator support for storage keys

sei-db/state_db/sc/flatkv/store.go

+		for _, paw := range s.accountWrites {
+			key := AccountKey(paw.addr)
+			if paw.isDelete {
+				if err := batch.Delete(key); err != nil {
+					return fmt.Errorf("accountDB delete: %w", err)
+				}
+			} else {
+				// Encode AccountValue and store with addr as key
+				encoded := EncodeAccountValue(paw.value)
+				if err := batch.Set(key, encoded); err != nil {
+					return fmt.Errorf("accountDB set: %w", err)
+				}
+			}
+		}


yzang2019 · 2026-02-05T06:47:45Z

sei-db/config/flatkv_config.go

+package config
+
+// FlatKVConfig defines configuration for the FlatKV (EVM) commit store.
+type FlatKVConfig struct {


Let's put this under flatkv package?

yzang2019 · 2026-02-05T06:51:50Z

sei-db/config/flatkv_config.go

+	// EnableStorageWrites enables writes to storageDB and its LtHash contribution.
+	// When false, storage data is skipped entirely (no DB writes, no LtHash updates).
+	// Default: true
+	EnableStorageWrites bool `mapstructure:"enable-storage-writes"`


Not sure why we want these configs, as long as dual write is true, all EVM state should be written to flatkv, and we don't need to control which key to write or not

yzang2019 · 2026-02-05T06:53:44Z

sei-db/config/flatkv_config.go

+	// When false (default): all writes use Sync=true for maximum durability.
+	// WAL and metaDB always use sync writes regardless of this setting.
+	// Default: false
+	AsyncWrites bool `mapstructure:"async-writes"`


Probably better to split into Fsync: bool and AsyncWriteBuffer: int

yzang2019 · 2026-02-05T06:54:11Z

sei-db/config/flatkv_config.go

+	// - 0 or 1: flush every block (safest, slowest)
+	// - N > 1: flush every N blocks (faster, recovers up to N blocks from WAL)
+	// Default: 100
+	FlushInterval int `mapstructure:"flush-interval"`


I think we don't need this config today, since we have to flush every block, we can add in the future if we really need it

yzang2019 · 2026-02-05T07:22:51Z

sei-db/state_db/sc/composite/store.go

-	// TODO: initialize FlatKV store for evmSC when cfg.WriteMode != config.CosmosOnlyWrite
+	// Initialize FlatKV store struct if write mode is not cosmos_only
+	// Note: DB is NOT opened here, will be opened in LoadVersion
+	if cfg.WriteMode != config.CosmosOnlyWrite {


Would recommend checking DualWrite or SplitWrite to determine whether we should initialize EMVCommitter

yzang2019 · 2026-02-05T07:27:18Z

sei-db/state_db/sc/composite/store.go

+	}
+
+	// Also load evmCommitter if enabled
+	if cs.config.WriteMode != config.CosmosOnlyWrite && cs.evmCommitter != nil {


We can remove this check cs.config.WriteMode != config.CosmosOnlyWrite since evmCommitter will be nil if write is not enabled

yzang2019 · 2026-02-05T07:27:49Z

sei-db/state_db/sc/composite/store.go

+	if cs.config.WriteMode != config.CosmosOnlyWrite && cs.evmCommitter != nil {
+		// Use LoadVersion on existing evmCommitter (matches memiavl pattern)
+		// This properly handles readOnly flag and avoids resource leaks
+		evmStore, err := cs.evmCommitter.LoadVersion(targetVersion, readOnly)


Not sure if we wanna call LoadVersion here, CMS will call LoadVersion as well, we need to make sure it's only called in one place

yzang2019 · 2026-02-05T07:32:34Z

sei-db/state_db/sc/flatkv/store.go

+)
+
+const (
+	// DB subdirectories


We need a legacyDB as well

yzang2019 · 2026-02-05T07:33:15Z

sei-db/state_db/sc/flatkv/store.go

+	metadataDir  = "metadata"
+
+	// Metadata DB keys
+	MetaGlobalVersion = "v" // Global committed version watermark (8 bytes)


suggest metadata key stored with _meta/version, _meta/hash

yzang2019 · 2026-02-05T07:43:07Z

sei-db/state_db/sc/flatkv/store_read.go

+
+// Get returns the value for the given memiavl key.
+// Returns (value, true) if found, (nil, false) if not found.
+func (s *CommitStore) Get(key []byte) ([]byte, bool) {


Why do we have store_read.go but not store_write.go? If we want to split, I was expecting to see read and write. Otherwise maybe we should just combine

chatgpt-codex-connector bot reviewed Feb 3, 2026

View reviewed changes

sei-db/state_db/sc/composite/store.go Show resolved Hide resolved

sei-db/state_db/sc/flatkv/store_read.go Outdated Show resolved Hide resolved

blindchaser added the non-app-hash-breaking label Feb 3, 2026

github-advanced-security bot found potential problems Feb 3, 2026

View reviewed changes

feat(sei-db): add flatkv store implementation

e3a525f

- Multi-DB storage: storageDB, accountDB, codeDB, metadataDB - LtHash-based state commitment using internal key formats - Configurable write toggles per DB type - Iterator support for storage keys

blindchaser force-pushed the yiren/flatkv-impl-rebased branch from 34a6fed to e3a525f Compare February 3, 2026 19:49

blindchaser added 3 commits February 3, 2026 15:00

fix lint

ff55b34

fix lint

239e372

refactor

1883bfb

github-advanced-security bot found potential problems Feb 3, 2026

View reviewed changes

blindchaser requested review from Kbhat1, jewei1997 and yzang2019 February 3, 2026 21:12

yzang2019 reviewed Feb 5, 2026

View reviewed changes

Conversation

blindchaser commented Feb 3, 2026

Describe your changes and provide context

Testing performed to validate your change

Uh oh!

github-actions bot commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Check warning

Check warning

Check warning

yzang2019 Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yzang2019 Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Feb 3, 2026 •

edited

Loading

codecov bot commented Feb 3, 2026 •

edited

Loading

yzang2019 Feb 5, 2026 •

edited

Loading

yzang2019 Feb 5, 2026 •

edited

Loading