add warning when running bounding box query if points is present #777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #777 +/- ##
=======================================
Coverage 91.79% 91.79%
=======================================
Files 45 45
Lines 7118 7120 +2
=======================================
+ Hits 6534 6536 +2
Misses 584 584
🚀 New features to boost your workflow:
|
…() to remove points element if needs performance boost
for more information, see https://pre-commit.ci
berombau
reviewed
Nov 14, 2024
| target_coordinate_system: str, | ||
| filter_table: bool = True, | ||
| ) -> SpatialData: | ||
| min_coordinate = _parse_list_into_array(min_coordinate) |
Contributor
There was a problem hiding this comment.
Add remark on performance with points to function documentation in Notes header
BioinfoTongLI
changed the title
LucaMarconato
approved these changes
Jan 5, 2025
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.