Test: Verify Enter key inserts new line (#440)#541
Test: Verify Enter key inserts new line (#440)#541andrewtavis merged 2 commits intoscribe-org:mainfrom
Conversation
Thank you for the pull request! 💙The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
|
|
Thanks so much for all the commits recently, @bhanu-dev82! |
andrewtavis
left a comment
There was a problem hiding this comment.
praise: All's looking great here, @bhanu-dev82! Thanks for picking up the issue and getting to the contribution so quickly!
|
Merging after tests pass :) |
Contributor checklist
./gradlew lintKotlin detekt testcommand as directed in the testing section of the contributing guideDescription
This PR adds a unit test to
KeyboardTest.ktto verify the behavior of the Enter key. It simulates pressing the Enter key via theKeyHandlerand asserts that the correspondingKeyEvents (ACTION_DOWN and ACTION_UP) are sent to theInputConnection.Changes
app/src/androidTest/kotlin/be/scri/helpers/KeyboardTest.kt: AddedtestEnterKeyInsertsNewLine.Related issue