Skip to content

Conversation

@lolgab
Copy link
Contributor

@lolgab lolgab commented Dec 18, 2025

@tgodzik tgodzik self-assigned this Dec 18, 2025
@tgodzik
Copy link
Contributor

tgodzik commented Dec 18, 2025

Thanks for working on this. Let me know when this is ready! Seems like github actions are having a tough day though, so we'll need to rerun some jobs.

@lolgab
Copy link
Contributor Author

lolgab commented Dec 18, 2025

Thanks for working on this. Let me know when this is ready! Seems like github actions are having a tough day though, so we'll need to rerun some jobs.

I want to port the tests as well, but I'm having trouble running the tests.

I get:

sbt:scala3-nonbootstrapped> last scala3-library-nonbootstrapped / scalaInstance
[error] java.lang.RuntimeException: Missing Scala tool configuration from the 'update' report.  Explicitly define scalaInstance or scalaHome or include Scala dependencies in the 'scala-tool' configuration.
[error]         at scala.sys.package$.error(package.scala:30)
[error]         at sbt.Defaults$.$anonfun$scalaInstanceFromUpdate$10(Defaults.scala:1214)
[error]         at scala.Option.getOrElse(Option.scala:189)
[error]         at sbt.Defaults$.$anonfun$scalaInstanceFromUpdate$1(Defaults.scala:1214)
[error]         at scala.Function1.$anonfun$compose$1(Function1.scala:49)
[error]         at
......
[error] (scala3-library-nonbootstrapped / scalaInstance) Missing Scala tool configuration from the 'update' report.  Explicitly define scalaInstance or scalaHome or include Scala dependencies in the 'scala-tool' configuration.

@tgodzik
Copy link
Contributor

tgodzik commented Dec 18, 2025

I think for coverage it should be sbt scala3-compiler-nonbootstrapped/testOnly dotty.tools.dotc.coverage.CoverageTests does it work for you?

@lolgab
Copy link
Contributor Author

lolgab commented Dec 18, 2025

@tgodzik Thank you. I needed to cleanup my workspace directory since I had last compiled Scala3 a long time ago and something was broken in the target directories. I can run tests now

@lolgab lolgab force-pushed the incremental-coverage branch 2 times, most recently from 6ac0a8f to 2017109 Compare December 18, 2025 19:07
@lolgab lolgab marked this pull request as ready for review December 18, 2025 19:48
@lolgab
Copy link
Contributor Author

lolgab commented Dec 19, 2025

@tgodzik I'm ready for review

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Could you rebase on main? It seems that something broke with the commit history

@lolgab lolgab force-pushed the incremental-coverage branch from 755f31e to 474948a Compare December 19, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants