This repository was archived by the owner on Aug 8, 2024. It is now read-only.
Now UTF-16 handling EOL fixup patch#42
Open
ned14 wants to merge 1 commit intoryppl:ned14-bad_eol_fixfrom
Open
Conversation
… a warning printed.
Member
|
w.r.t. intentionally-bad line endings, you can just mark those specific filenames as binary in .gitattributes, can't you? |
Member
Author
|
@dabrahams You can add any glob matching said files to .gitattributes e.g. bad_eol_test*.txt or whatever. Full paths also qualify of course, but I'm thinking some wildcard pattern or special file extension to indicate deliberately malformed text would help users transition their files correctly. Even adding a .bin extension would be enough I think. |
Member
Author
|
How has this patchset fared? Does it solve the original problem successfully? Niall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passes the boost SVN Dave sent me. I now know why my boost svnsynced copy didn't fault - I didn't sync sandbox, and sandbox is what contains the UTF-16.
BTW a quick note: some of the warnings about having to convert EOL in some of the sandbox files refer to filenames saying something like "bad_end_of_line_test.txt". I am almost certain that files named like that have intentionally incorrect EOLs and they want them to stay that way.
I'd recommend those affected to not use .txt for such test files (which stops Boost2Git messing with the file), and it might be an idea to add a new "binary text" extension to gitattributes for that sort of file to ensure git doesn't try fiddling with the contents either during checkout.
Niall