Skip to content

Move rand_pcg to the rust-random/rngs repository#1740

Merged
dhardy merged 2 commits intomasterfrom
move_rand_pcg
Feb 9, 2026
Merged

Move rand_pcg to the rust-random/rngs repository#1740
dhardy merged 2 commits intomasterfrom
move_rand_pcg

Conversation

@newpavlov
Copy link
Member

Sibling rngs PR: rust-random/rngs#103

Closes #1685

@newpavlov newpavlov requested a review from dhardy February 9, 2026 14:59
@newpavlov newpavlov changed the title Move rand_pcg to the rand/rngs repository Move rand_pcg to the rust-random/rngs repository Feb 9, 2026
Copy link
Member

@dhardy dhardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other PR should be merged first.

dhardy pushed a commit to rust-random/rngs that referenced this pull request Feb 9, 2026
The crate is moved from `rust-random/rand` without any code changes.

Sibling `rand` PR: rust-random/rand#1740
@dhardy
Copy link
Member

dhardy commented Feb 9, 2026

Eventually we should migrate to the Xoshiro* RNGs included in rand, but this is fine for now.

@dhardy dhardy merged commit 87638fb into master Feb 9, 2026
17 checks passed
@dhardy dhardy deleted the move_rand_pcg branch February 9, 2026 18:47
@newpavlov
Copy link
Member Author

we should migrate to the Xoshiro* RNGs included in rand

Probably it's worth to create an issue for that.

@dhardy
Copy link
Member

dhardy commented Feb 10, 2026

we should migrate to the Xoshiro* RNGs included in rand

Or not. I was forgetting that rand::text::rng() uses Pcg32 (for value stability tests). If dependencies ever become an issue it would be far easier just to embed Pcg32.

As for the benchmarks, replacing the algorithm would be much easier but we also don't have a reason to do so right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move rand_pcg to the rngs repository?

2 participants