Closed
Conversation
In the `fn round` I changed `one` from a `Ratio<t>` to `T` because addition with a integer is quicker. In `Neg::neg` for `Ratio<T>`, the value is changed in place. I think this might prevent some memory from being moved or allocated. In `Inv::inv`, I changed `recip` to `into_recip` to prevent a clone operation.
mikem8891
added a commit
to mikem8891/num-rational
that referenced
this pull request
Mar 13, 2026
Fixes rust-num#143 and closes rust-num#149 . This PR supersedes rust-num#144 , rust-num#145 , rust-num#148 .
Author
|
Superseded by #150 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the
fn roundI changedonefrom aRatio<T>toTbecause addition with a integer is quicker, avoids alcmcall, and someclonecalls.In
Neg::negforRatio<T>, the value is changed in place. I think this might prevent some memory from being moved or allocated.In
Inv::inv, I changedreciptointo_recipto prevent a clone operation. This is in the spirit of #110.