Closed
Conversation
The current code for `to_integer` calls `trunc` which calculates the integer then wraps it in a `Ratio<T>` then `to_integer` unwraps the `numer` that `trunc` returned. This commit skips the extra steps.
mikem8891
added a commit
to mikem8891/num-rational
that referenced
this pull request
Mar 13, 2026
Fixes rust-num#143 and closes rust-num#149 . This PR supersedes rust-num#144 , rust-num#145 , rust-num#148 .
Author
|
Superseded by #150 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current code for
to_integercallstruncwhich calculates the integer then wraps it in aRatio<T>thento_integerunwraps thenumerthattruncreturned. This pull request skips the extra steps.This highlights some of the absurdity in that
truc,round,floor, andceilreturn integers wrapped inRatio<T>instead of the underlying typeTand for 3 of those functions (round,floor, andceil) there are no functions provided to get the integers directly.