Skip to content

Conversation

@matthiaskrgr
Copy link
Member

@matthiaskrgr matthiaskrgr commented Dec 14, 2025

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

RalfJung and others added 30 commits December 6, 2025 16:06
fix empty stack in deadlock error message
run ptr_int tests with Tree Borrows
genmc: suppress compare_exchange warnings from dependencies
…cked

ftruncate: return proper error code for non-file-backed FDs
…or-protector-release

TreeBorrows: split `Tree::perform_protector_release_access` from `Tree::perform_access`
…ions

Remove `[no-mentions]` handler in the triagebot config
…or-diagnostics-struct

TreeBorrows: Put accesses diagnostic parameters into a single struct
This commit is a follow-up to 147572 and the issue reported at the end
of that PR where the `std::fs::hard_link` function is broken after that
PR landed. The true culprit and bug here is fixed in
WebAssembly/wasi-libc/690 but until that's released in a wasi-sdk
version it should be reasonable, on WASI, to skip the `linkat`
function.
This updates the rust-version file to f520900.
Pull recent changes from https://github.com/rust-lang/rust via Josh.

Upstream ref: f520900
Filtered ref: 7d63be37076f39216080a677b88ad18621850d0c
Upstream diff: rust-lang/rust@36b2369...f520900

This merge was created using https://github.com/rust-lang/josh-sync.
README: add more papers to the paper list
This updates the rust-version file to dc47a69.
Pull recent changes from https://github.com/rust-lang/rust via Josh.

Upstream ref: dc47a69
Filtered ref: c2685dab4096194918f1cb9c503817d592c20e94
Upstream diff: rust-lang/rust@f520900...dc47a69

This merge was created using https://github.com/rust-lang/josh-sync.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Dec 14, 2025
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=5

@bors
Copy link
Collaborator

bors commented Dec 14, 2025

📌 Commit b655ea3 has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 14, 2025
@bors
Copy link
Collaborator

bors commented Dec 14, 2025

⌛ Testing commit b655ea3 with merge 0f12db2...

bors added a commit that referenced this pull request Dec 14, 2025
Rollup of 8 pull requests

Successful merges:

 - #146794 (std: reorganize pipe implementations)
 - #148490 (dangling pointer from temp cleanup)
 - #149837 (Update `wrapping_sh[lr]` docs and examples)
 - #149864 (std: Don't use `linkat` on the `wasm32-wasi*` targets)
 - #149885 (replace addr_of_mut with &raw mut in maybeuninit docs)
 - #149949 (Cleanup of attribute parsing errors)
 - #149969 (don't use no_main and no_core to test IBT)
 - #149998 (miri subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
Copy link
Collaborator

bors commented Dec 15, 2025

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 15, 2025
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@matthiaskrgr
Copy link
Member Author

matthiaskrgr commented Dec 15, 2025

@bors retry single runner timed out

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 15, 2025
@bors
Copy link
Collaborator

bors commented Dec 15, 2025

⌛ Testing commit b655ea3 with merge 52fda2e...

@bors
Copy link
Collaborator

bors commented Dec 15, 2025

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 52fda2e to main...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 15, 2025
@bors bors merged commit 52fda2e into rust-lang:main Dec 15, 2025
12 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Dec 15, 2025
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#146794 std: reorganize pipe implementations 815fcd72baaa5b030848dac36020b859883fa05a (link)
#148490 dangling pointer from temp cleanup 3626059062c52b733c30d1abb6561a341b2f9694 (link)
#149837 Update wrapping_sh[lr] docs and examples 55b8433727c23f6006860a1a93e7a48a2d5350f2 (link)
#149864 std: Don't use linkat on the wasm32-wasi* targets a92e2fc34caf6f046c5eb462fc33d0a379541b09 (link)
#149885 replace addr_of_mut with &raw mut in maybeuninit docs 8967a554dc3c2a7c72da2d265c1eb09aa6c0756f (link)
#149949 Cleanup of attribute parsing errors 6385287c53dd30db910e86e50ee500216f3cc274 (link)
#149969 don't use no_main and no_core to test IBT d399792182de1d49ae04a4629fd95f15c22b34a6 (link)
#149998 miri subtree update a47c2a91387aa4c27a690ba15fe67cedf0002ef0 (link)

previous master: 0208ee09be

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 0208ee0 (parent) -> 52fda2e (this PR)

Test differences

Show 3062 test diffs

Stage 0

  • session_diagnostics::verify_attr_parsing_as_needed_compatibility_59: [missing] -> pass (J0)
  • session_diagnostics::verify_attr_parsing_as_needed_compatibility_60: pass -> [missing] (J0)
  • session_diagnostics::verify_attr_parsing_bundle_needs_static_58: pass -> [missing] (J0)
  • session_diagnostics::verify_attr_parsing_doc_alias_malformed_62: [missing] -> pass (J0)
  • session_diagnostics::verify_attr_parsing_doc_alias_malformed_63: pass -> [missing] (J0)
  • session_diagnostics::verify_attr_parsing_empty_link_name_48: [missing] -> pass (J0)
  • session_diagnostics::verify_attr_parsing_empty_link_name_49: pass -> [missing] (J0)
  • session_diagnostics::verify_attr_parsing_import_name_type_raw_60: [missing] -> pass (J0)
  • session_diagnostics::verify_attr_parsing_import_name_type_raw_61: pass -> [missing] (J0)
  • session_diagnostics::verify_attr_parsing_import_name_type_x86_56: [missing] -> pass (J0)
  • session_diagnostics::verify_attr_parsing_import_name_type_x86_57: pass -> [missing] (J0)
  • session_diagnostics::verify_attr_parsing_incompatible_wasm_link_51: pass -> [missing] (J0)
  • session_diagnostics::verify_attr_parsing_invalid_alignment_value_40: [missing] -> pass (J0)
  • session_diagnostics::verify_attr_parsing_invalid_attr_unsafe_46: [missing] -> pass (J0)
  • session_diagnostics::verify_attr_parsing_invalid_attr_unsafe_47: pass -> [missing] (J0)
  • session_diagnostics::verify_attr_parsing_invalid_link_modifier_54: [missing] -> pass (J0)
  • session_diagnostics::verify_attr_parsing_invalid_target_40: pass -> [missing] (J0)
  • session_diagnostics::verify_attr_parsing_limit_invalid_61: [missing] -> pass (J0)
  • session_diagnostics::verify_attr_parsing_limit_invalid_62: pass -> [missing] (J0)
  • session_diagnostics::verify_attr_parsing_link_framework_apple_50: pass -> [missing] (J0)
  • session_diagnostics::verify_attr_parsing_link_ordinal_out_of_range_45: [missing] -> pass (J0)
  • session_diagnostics::verify_attr_parsing_link_ordinal_out_of_range_46: pass -> [missing] (J0)
  • session_diagnostics::verify_attr_parsing_link_requires_name_51: [missing] -> pass (J0)
  • session_diagnostics::verify_attr_parsing_link_requires_name_52: pass -> [missing] (J0)
  • session_diagnostics::verify_attr_parsing_multiple_modifiers_55: [missing] -> pass (J0)
  • session_diagnostics::verify_attr_parsing_multiple_modifiers_56: pass -> [missing] (J0)
  • session_diagnostics::verify_attr_parsing_naked_functions_incompatible_attribute_45: pass -> [missing] (J0)
  • session_diagnostics::verify_attr_parsing_null_on_export_31: [missing] -> pass (J0)
  • session_diagnostics::verify_attr_parsing_null_on_export_32: pass -> [missing] (J0)
  • session_diagnostics::verify_attr_parsing_null_on_link_section_32: [missing] -> pass (J0)
  • session_diagnostics::verify_attr_parsing_null_on_link_section_33: pass -> [missing] (J0)
  • session_diagnostics::verify_attr_parsing_null_on_objc_class_33: [missing] -> pass (J0)
  • session_diagnostics::verify_attr_parsing_null_on_objc_class_34: pass -> [missing] (J0)
  • session_diagnostics::verify_attr_parsing_null_on_objc_selector_34: [missing] -> pass (J0)
  • session_diagnostics::verify_attr_parsing_objc_class_expected_string_literal_35: [missing] -> pass (J0)
  • session_diagnostics::verify_attr_parsing_objc_class_expected_string_literal_36: pass -> [missing] (J0)
  • session_diagnostics::verify_attr_parsing_objc_selector_expected_string_literal_36: [missing] -> pass (J0)
  • session_diagnostics::verify_attr_parsing_objc_selector_expected_string_literal_37: pass -> [missing] (J0)
  • session_diagnostics::verify_attr_parsing_raw_dylib_no_nul_52: [missing] -> pass (J0)
  • session_diagnostics::verify_attr_parsing_raw_dylib_only_windows_53: [missing] -> pass (J0)
  • session_diagnostics::verify_attr_parsing_raw_dylib_only_windows_54: pass -> [missing] (J0)
  • session_diagnostics::verify_attr_parsing_repr_ident_42: pass -> [missing] (J0)
  • session_diagnostics::verify_attr_parsing_stability_outside_std_38: pass -> [missing] (J0)
  • session_diagnostics::verify_attr_parsing_suffixed_literal_in_attribute_47: [missing] -> pass (J0)
  • session_diagnostics::verify_attr_parsing_suffixed_literal_in_attribute_48: pass -> [missing] (J0)
  • session_diagnostics::verify_attr_parsing_unrecognized_repr_hint_42: [missing] -> pass (J0)
  • session_diagnostics::verify_attr_parsing_unstable_feature_bound_incompatible_stability_43: [missing] -> pass (J0)
  • session_diagnostics::verify_attr_parsing_unstable_feature_bound_incompatible_stability_44: pass -> [missing] (J0)
  • session_diagnostics::verify_attr_parsing_whole_archive_needs_static_58: [missing] -> pass (J0)
  • session_diagnostics::verify_attr_parsing_whole_archive_needs_static_59: pass -> [missing] (J0)

Stage 1

  • session_diagnostics::verify_attr_parsing_bundle_needs_static_57: [missing] -> pass (J1)
  • session_diagnostics::verify_attr_parsing_bundle_needs_static_58: pass -> [missing] (J1)
  • session_diagnostics::verify_attr_parsing_doc_alias_malformed_62: [missing] -> pass (J1)
  • session_diagnostics::verify_attr_parsing_doc_alias_malformed_63: pass -> [missing] (J1)
  • session_diagnostics::verify_attr_parsing_empty_confusables_38: [missing] -> pass (J1)
  • session_diagnostics::verify_attr_parsing_empty_confusables_39: pass -> [missing] (J1)
  • session_diagnostics::verify_attr_parsing_empty_link_name_48: [missing] -> pass (J1)
  • session_diagnostics::verify_attr_parsing_ill_formed_attribute_input_31: pass -> [missing] (J1)
  • session_diagnostics::verify_attr_parsing_import_name_type_raw_60: [missing] -> pass (J1)
  • session_diagnostics::verify_attr_parsing_import_name_type_raw_61: pass -> [missing] (J1)
  • session_diagnostics::verify_attr_parsing_import_name_type_x86_56: [missing] -> pass (J1)
  • session_diagnostics::verify_attr_parsing_import_name_type_x86_57: pass -> [missing] (J1)
  • session_diagnostics::verify_attr_parsing_incompatible_wasm_link_50: [missing] -> pass (J1)
  • session_diagnostics::verify_attr_parsing_invalid_alignment_value_40: [missing] -> pass (J1)
  • session_diagnostics::verify_attr_parsing_invalid_alignment_value_41: pass -> [missing] (J1)
  • session_diagnostics::verify_attr_parsing_invalid_attr_unsafe_46: [missing] -> pass (J1)
  • session_diagnostics::verify_attr_parsing_invalid_link_modifier_54: [missing] -> pass (J1)
  • session_diagnostics::verify_attr_parsing_invalid_link_modifier_55: pass -> [missing] (J1)
  • session_diagnostics::verify_attr_parsing_invalid_target_39: [missing] -> pass (J1)
  • session_diagnostics::verify_attr_parsing_limit_invalid_62: pass -> [missing] (J1)
  • session_diagnostics::verify_attr_parsing_link_framework_apple_49: [missing] -> pass (J1)
  • session_diagnostics::verify_attr_parsing_link_framework_apple_50: pass -> [missing] (J1)
  • session_diagnostics::verify_attr_parsing_link_ordinal_out_of_range_45: [missing] -> pass (J1)
  • session_diagnostics::verify_attr_parsing_link_ordinal_out_of_range_46: pass -> [missing] (J1)
  • session_diagnostics::verify_attr_parsing_link_requires_name_51: [missing] -> pass (J1)
  • session_diagnostics::verify_attr_parsing_link_requires_name_52: pass -> [missing] (J1)
  • session_diagnostics::verify_attr_parsing_naked_functions_incompatible_attribute_44: [missing] -> pass (J1)
  • session_diagnostics::verify_attr_parsing_null_on_export_31: [missing] -> pass (J1)
  • session_diagnostics::verify_attr_parsing_null_on_export_32: pass -> [missing] (J1)
  • session_diagnostics::verify_attr_parsing_null_on_link_section_32: [missing] -> pass (J1)
  • session_diagnostics::verify_attr_parsing_null_on_link_section_33: pass -> [missing] (J1)
  • session_diagnostics::verify_attr_parsing_null_on_objc_class_33: [missing] -> pass (J1)
  • session_diagnostics::verify_attr_parsing_null_on_objc_selector_34: [missing] -> pass (J1)
  • session_diagnostics::verify_attr_parsing_objc_class_expected_string_literal_35: [missing] -> pass (J1)
  • session_diagnostics::verify_attr_parsing_objc_selector_expected_string_literal_36: [missing] -> pass (J1)
  • session_diagnostics::verify_attr_parsing_objc_selector_expected_string_literal_37: pass -> [missing] (J1)
  • session_diagnostics::verify_attr_parsing_raw_dylib_no_nul_52: [missing] -> pass (J1)
  • session_diagnostics::verify_attr_parsing_raw_dylib_only_windows_54: pass -> [missing] (J1)
  • session_diagnostics::verify_attr_parsing_repr_ident_41: [missing] -> pass (J1)
  • session_diagnostics::verify_attr_parsing_repr_ident_42: pass -> [missing] (J1)
  • session_diagnostics::verify_attr_parsing_stability_outside_std_38: pass -> [missing] (J1)
  • session_diagnostics::verify_attr_parsing_suffixed_literal_in_attribute_48: pass -> [missing] (J1)
  • session_diagnostics::verify_attr_parsing_unrecognized_repr_hint_42: [missing] -> pass (J1)
  • session_diagnostics::verify_attr_parsing_unrecognized_repr_hint_43: pass -> [missing] (J1)
  • session_diagnostics::verify_attr_parsing_unstable_feature_bound_incompatible_stability_43: [missing] -> pass (J1)
  • session_diagnostics::verify_attr_parsing_unstable_feature_bound_incompatible_stability_44: pass -> [missing] (J1)
  • session_diagnostics::verify_attr_parsing_whole_archive_needs_static_58: [missing] -> pass (J1)
  • session_diagnostics::verify_attr_parsing_whole_archive_needs_static_59: pass -> [missing] (J1)

Stage 2

  • sys::pal::windows::handle::tests::overlapped_handle_fallback: pass -> [missing] (J2)
  • sys::process::windows::tests::overlapped_handle_fallback: [missing] -> pass (J2)

(and 32 additional test diffs)

Additionally, 2930 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 52fda2e54f805722807c90e91ac3329fe9e7ccb3 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-aarch64-linux: 6102.2s -> 8826.6s (+44.6%)
  2. aarch64-apple: 8723.1s -> 10871.8s (+24.6%)
  3. dist-aarch64-apple: 5698.1s -> 6976.5s (+22.4%)
  4. x86_64-rust-for-linux: 2677.3s -> 3238.0s (+20.9%)
  5. i686-gnu-2: 5107.9s -> 6035.8s (+18.2%)
  6. x86_64-gnu-llvm-20: 2432.1s -> 2838.6s (+16.7%)
  7. x86_64-gnu-gcc: 3028.2s -> 3477.3s (+14.8%)
  8. dist-x86_64-apple: 6270.9s -> 7149.7s (+14.0%)
  9. x86_64-gnu-llvm-20-1: 3960.1s -> 4507.3s (+13.8%)
  10. test-various: 6633.0s -> 7522.3s (+13.4%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (52fda2e): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
0.1% [0.1%, 0.1%] 1
Regressions ❌
(secondary)
0.2% [0.2%, 0.2%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.1% [-0.1%, -0.1%] 1
All ❌✅ (primary) 0.1% [0.1%, 0.1%] 1

Max RSS (memory usage)

Results (primary 0.4%, secondary 0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.7% [2.7%, 2.7%] 1
Regressions ❌
(secondary)
3.1% [3.1%, 3.1%] 1
Improvements ✅
(primary)
-1.9% [-1.9%, -1.9%] 1
Improvements ✅
(secondary)
-1.4% [-2.0%, -0.8%] 2
All ❌✅ (primary) 0.4% [-1.9%, 2.7%] 2

Cycles

Results (secondary 2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.9% [2.5%, 3.3%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

Results (secondary 0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.1% [0.1%, 0.1%] 4
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Bootstrap: 479.155s -> 479.867s (0.15%)
Artifact size: 390.26 MiB -> 390.23 MiB (-0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) A-run-make Area: port run-make Makefiles to rmake.rs merged-by-bors This PR was explicitly merged by bors. O-hermit Operating System: Hermit O-SGX Target: SGX O-solid Operating System: SOLID O-unix Operating system: Unix-like O-wasi Operating system: Wasi, Webassembly System Interface O-wasm Target: WASM (WebAssembly), http://webassembly.org/ O-windows Operating system: Windows rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.