-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
Remove uses of &mut CmResolver
#148187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
LorrensP-2158466
wants to merge
1
commit into
rust-lang:main
Choose a base branch
from
LorrensP-2158466:cm-res-variance
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Remove uses of &mut CmResolver
#148187
+10
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @petrochenkov Because you reviewed and approved the first pr and because it's linked to our work in #145108 |
lcnr
reviewed
Oct 29, 2025
25e2a49 to
9e9e361
Compare
Contributor
Author
&mut CmResolver
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Collaborator
|
☔ The latest upstream changes (presumably #149462) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added a commit
that referenced
this pull request
Dec 20, 2025
Better closure requirement propagation. Fixes #148289 Fixes #104477 Should unblock #148187 When propagating closure requirements we: - no longer try to find a post dominiting region for the list of non-local lower bounds of `longer_fr`. - we filter the list of `longer_fr-: shorter_fr+` to only these constraints between external regions which are required regardless. If no such constraint exists, we fall back to propagating all of them. See the [FCP](#148329 (comment)) for more information. r? `@lcnr`
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Dec 21, 2025
Better closure requirement propagation. Fixes rust-lang/rust#148289 Fixes rust-lang/rust#104477 Should unblock rust-lang/rust#148187 When propagating closure requirements we: - no longer try to find a post dominiting region for the list of non-local lower bounds of `longer_fr`. - we filter the list of `longer_fr-: shorter_fr+` to only these constraints between external regions which are required regardless. If no such constraint exists, we fall back to propagating all of them. See the [FCP](rust-lang/rust#148329 (comment)) for more information. r? `@lcnr`
Kobzol
pushed a commit
to Kobzol/rustc_codegen_gcc
that referenced
this pull request
Dec 21, 2025
Better closure requirement propagation. Fixes rust-lang/rust#148289 Fixes rust-lang/rust#104477 Should unblock rust-lang/rust#148187 When propagating closure requirements we: - no longer try to find a post dominiting region for the list of non-local lower bounds of `longer_fr`. - we filter the list of `longer_fr-: shorter_fr+` to only these constraints between external regions which are required regardless. If no such constraint exists, we fall back to propagating all of them. See the [FCP](rust-lang/rust#148329 (comment)) for more information. r? `@lcnr`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-blocked
Status: Blocked on something else such as an RFC or other implementation work.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some places where we use a
&mut CmResolverinside ofFnMutarguments. That is because when we doCmResolver::reborrow()inside of a closure, it fails to compile due to region constraints. This pr changes these to bareCmResolverarguments.When #148329 is merged, this can be merged as well.
r? @petrochenkov