Skip to content

coverage: Rearrange the code for embedding per-function coverage metadata#134163

Merged
bors merged 5 commits intorust-lang:masterfrom
Zalathar:covfun
Dec 11, 2024
Merged

coverage: Rearrange the code for embedding per-function coverage metadata#134163
bors merged 5 commits intorust-lang:masterfrom
Zalathar:covfun

Conversation

@Zalathar
Copy link
Member

@Zalathar Zalathar commented Dec 11, 2024

This is a series of refactorings to the code that prepares and embeds per-function coverage metadata records (“covfun records”) in the __llvm_covfun linker section of the final binary. The llvm-cov tool reads this metadata from the binary when preparing a coverage report.

Beyond general cleanup, a big motivation behind these changes is to pave the way for re-landing an updated version of #133418.


There should be no change in compiler output, as demonstrated by the absence of (meaningful) changes to coverage tests.

The first patch is just moving code around, so I suggest looking at the other patches to see the actual changes.


try-job: x86_64-gnu
try-job: x86_64-msvc
try-job: aarch64-apple

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-code-coverage Area: Source-based code coverage (-Cinstrument-coverage) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants