Skip to content

📚 Fix rdoc 7.2 compatibility (section bugfix) #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nevans merged 1 commit into from
Feb 24, 2026
Merged

📚 Fix rdoc 7.2 compatibility (section bugfix) #617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ gem "psych", ">= 5.3.0" # 5.2.5 for Data serialization, 5.3.0 for TruffleRuby

gem "irb"
gem "rake"
gem "rdoc"
gem "rdoc", ">= 7.2.0"
gem "test-unit"
gem "test-unit-ruby-core", git: "https://github.com/ruby/test-unit-ruby-core"

Expand Down
15 changes: 0 additions & 15 deletions rakelib/rdoc.rake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,17 +12,6 @@ module RDoc::Generator
end
end

# See https://github.com/ruby/rdoc/pull/936
module FixSectionComments
def markup(text)
@store ||= @parent&.store
super
end
def description; markup comment end
def comment; super || @comments&.first end
def parse(_comment_location = nil) super() end
end

# render "[label] data" lists as tables. adapted from "hanna-nouveau" gem.
module LabelListTable
def list_item_start(list_item, list_type)
Expand Down Expand Up @@ -51,10 +40,6 @@ class RDoc::AnyMethod
prepend RDoc::Generator::NetIMAP::RemoveRedundantParens
end

class RDoc::Context::Section
prepend RDoc::Generator::NetIMAP::FixSectionComments
end

class RDoc::Markup::ToHtml
LIST_TYPE_TO_HTML[:NOTE] = ['<table class="rdoc-list note-list"><tbody>', '</tbody></table>']
prepend RDoc::Generator::NetIMAP::LabelListTable
Expand Down