Skip to content

chore: move k8s in to deploy folder#4189

Open
NathanFlurry wants to merge 1 commit intomainfrom
02-12-chore_move_k8s_in_to_deploy_folder
Open

chore: move k8s in to deploy folder#4189
NathanFlurry wants to merge 1 commit intomainfrom
02-12-chore_move_k8s_in_to_deploy_folder

Conversation

@NathanFlurry
Copy link
Member

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@railway-app
Copy link

railway-app bot commented Feb 12, 2026

🚅 Deployed to the rivet-pr-4189 environment in rivet-frontend

Service Status Web Updated (UTC)
website 😴 Sleeping (View Logs) Web Feb 12, 2026 at 9:43 pm
frontend-inspector ❌ Build Failed (View Logs) Web Feb 12, 2026 at 9:34 pm
frontend-cloud ❌ Build Failed (View Logs) Web Feb 12, 2026 at 9:33 pm
mcp-hub ✅ Success (View Logs) Web Feb 12, 2026 at 9:33 pm
ladle ❌ Build Failed (View Logs) Web Feb 12, 2026 at 9:32 pm

Copy link
Member Author


How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@claude
Copy link

claude bot commented Feb 12, 2026

PR Review

This PR reorganizes the repository by moving Kubernetes deployment files into a dedicated deploy/ directory and removing outdated spec documents. Overall, this is a clean organizational change that improves the repository structure.

✅ Strengths

  1. Better Organization: Moving k8s files to deploy/k8s/ creates a clearer structure for deployment-related resources
  2. Documentation Cleanup: Removing outdated spec files (sqlite-vfs-rust-wasm.md and workflow.md) helps prevent confusion
  3. CLAUDE.md Enhancement: The new "Notes" section provides clear guidance for agent note-taking

🐛 Issues Found

Critical: Broken Path Reference

File: scripts/run/k8s/engine.sh:40

The script still references the old path:

cd "${REPO_ROOT}/k8s/engine"

Fix needed:

cd "${REPO_ROOT}/deploy/k8s/engine"

This will cause the script to fail when executed, as the directory no longer exists at the old location.

📋 Recommendations

  1. Update the broken path in scripts/run/k8s/engine.sh before merging
  2. Test the script after the fix to ensure the k8s deployment still works
  3. Consider a PR description: The PR body is empty except for the template. A brief summary like "Reorganize k8s files into deploy/ directory and remove outdated specs" would be helpful for reviewers

🔍 Additional Checks

  • ✅ No other references to the old k8s/ path found in code
  • ✅ All moved files are pure renames (no content changes)
  • ✅ The deploy/ directory structure is clean and logical
  • ✅ README files in the new location reference the correct relative paths

Summary

This is a straightforward refactoring PR that improves repository organization. Once the path reference in scripts/run/k8s/engine.sh is fixed, this should be good to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant