Conversation
|
🚅 Deployed to the rivet-pr-4181 environment in rivet-frontend
|
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Code ReviewThis PR contains several fixes for Docker cache issues and dashboard improvements. Here's my analysis: ✅ Positive Changes1. Critical Bug Fix in Gasoline Worker Distribution (
|
| "legendFormat": "{{worker_id}}", | ||
| "expr": "sum by (sub_workflow_name) (rate(rivet_gasoline_workflow_dispatched_total{rivet_project=~\"$project\",rivet_datacenter=~\"$datacenter\",workflow_name=~\"$workflow_name\"} [$__rate_interval]))", | ||
| "format": "heatmap", | ||
| "legendFormat": "{{signal_name}}", |
There was a problem hiding this comment.
Legend format references {{signal_name}} but the query groups by sub_workflow_name. This mismatch will result in empty or incorrect legend labels.
Fix:
"legendFormat": "{{sub_workflow_name}}",| "legendFormat": "{{signal_name}}", | |
| "legendFormat": "{{sub_workflow_name}}", |
Spotted by Graphite Agent
Is this helpful? React 👍 or 👎 to let us know.
| "editorMode": "code", | ||
| "expr": "sum(increase(rivet_gasoline_load_shedding_ratio_bucket{rivet_project=~\"$project\",rivet_datacenter=~\"$datacenter\"} [$__rate_interval])) by (le)", | ||
| "expr": "sum by (sub_workflow_name) (rate(rivet_gasoline_workflow_dispatched_total{rivet_project=~\"$project\",rivet_datacenter=~\"$datacenter\",workflow_name=\"\"} [$__rate_interval]))", | ||
| "format": "heatmap", |
There was a problem hiding this comment.
Format is set to "heatmap" but the panel type is "timeseries" (line 1724). This format mismatch will cause visualization errors.
Fix:
"format": "time_series",Or remove the format field entirely to use the default for timeseries panels.
| "format": "heatmap", | |
| "format": "time_series", |
Spotted by Graphite Agent
Is this helpful? React 👍 or 👎 to let us know.

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: