Fix: Handle filenames with spaces in mob next #474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Git's porcelain output quotes filenames containing spaces. The getPathOfLastModifiedFile function was passing these quoted filenames directly to os.Stat, causing failures on mob next. - Unquote git-quoted filenames before calling os.Stat. - Handle unquoting errors gracefully with warning messages. - Bump version to 5.4.1.
Member
|
Hi @aglet thank you for your contribution. At the moment I am busy and will need some time to review your changes. Hopefully I will find some time next week to have a look at it! |
gregorriegler
merged commit e88223c
into
remotemobprogramming:main
5 of 6 checks passed
Collaborator
|
Awesome, thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Git's porcelain output quotes filenames containing spaces. The getPathOfLastModifiedFile function was passing these quoted filenames directly to os.Stat, causing failures on mob next.