Skip to content

fix: cloudwatch integrations tests#4033

Merged
squiidz merged 1 commit intomainfrom
fix_integrations_tests_cloudwatch_logs
Mar 4, 2026
Merged

fix: cloudwatch integrations tests#4033
squiidz merged 1 commit intomainfrom
fix_integrations_tests_cloudwatch_logs

Conversation

@squiidz
Copy link
Contributor

@squiidz squiidz commented Feb 27, 2026

No description provided.

@claude
Copy link

claude bot commented Feb 27, 2026

Claude finished @squiidz's task in 2m 25s —— View job


  • Validate commit policy
  • Review code changes
  • Post summary

Commits

  1. fix: cloudwatch integrations tests — leading space in message; format should be system: message (e.g., aws: fix cloudwatch integration tests)

Review
The PR replaces integration.StreamTests framework usage with direct cloudWatchLogsInput struct testing, adds proper message count and content assertions, and extracts two reusable helpers (newTestCWLClient, collectMessages). The changes improve test coverage (structured JSON output verification) and make the tests more targeted. Import organization and cleanup patterns follow project conventions.

LGTM


@@ -16,6 +16,7 @@ package aws

import (
"context"
"encoding/json"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message format violation: The commit message fix: cloudwatch integrations tests has a leading space and doesn't follow the project's commit policy. Expected format is system: message with an imperative lowercase message and a known system name as prefix. Consider: aws: fix cloudwatch integration tests.

@mmatczuk
Copy link
Contributor

@squiidz could we have CI hook where we could run /task XXX to run task XXX on a branch. We need to be able to test such changes.

@squiidz
Copy link
Contributor Author

squiidz commented Feb 27, 2026

/test ./internal/impl/aws

@squiidz squiidz force-pushed the fix_integrations_tests_cloudwatch_logs branch from 75dcee2 to 12aae32 Compare March 4, 2026 14:23
@claude
Copy link

claude bot commented Mar 4, 2026

Claude finished @squiidz's task in 1m 6s —— View job


  • Validate commit policy
  • Review code changes
  • Post summary

Commits

  1. fix merge conflict — plain sentence-case messages must have the first word capitalized per commit policy. Expected: Fix merge conflict (or better, squash into a single aws: fix cloudwatch integration tests commit before merge).

Review
The PR replaces integration.StreamTests framework usage with direct cloudWatchLogsInput struct testing, adds structured JSON output verification, and extracts reusable helpers (newTestCWLClient, collectMessages). Import organization and cleanup patterns follow project conventions.

LGTM


@squiidz squiidz merged commit d93ffbb into main Mar 4, 2026
7 checks passed
@squiidz squiidz deleted the fix_integrations_tests_cloudwatch_logs branch March 4, 2026 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants