Conversation
Collaborator
|
@abrookins looks like we need to resolve |
tylerhutcherson
approved these changes
Feb 15, 2026
sentence-transformers (via transformers) doesn't fully support Python 3.14 yet. Skip tests that depend on HFTextVectorizer and HFCrossEncoderReranker on 3.14.
e571e75 to
1b01efc
Compare
vishal-bala
approved these changes
Feb 16, 2026
Collaborator
vishal-bala
left a comment
There was a problem hiding this comment.
LGTM - seems a bit painful until sentence-transformers catches up 😄
Also, maybe we should settle on a timeline for dropping Python 3.9 support, since it reached EoL back in October. No rush, but might let us simplify some things (and also reduce the matrix testing).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add Python 3.14 support to RedisVL.
Changes
requires-pythonupper bound from<3.14to<3.15Programming Language :: Python :: 3.14classifierTesting Strategy
HuggingFace/sentence-transformers tests are skipped on Python 3.14 because the upstream
transformerslibrary doesn't fully support Python 3.14 yet.Affected components (all optional):
HFTextVectorizerHFCrossEncoderRerankerSemanticRouter(when using default HF vectorizer)SemanticMessageHistory(when using HF vectorizer)Users can still use these features on Python 3.9-3.13, or use alternative vectorizers (OpenAI, Cohere, etc.) on Python 3.14.
Implementation:
SKIP_HFconstant inconftest.pyto detect Python 3.14+pytestmark@pytest.mark.requires_hfmarkerpytest.param(..., marks=...)Once
transformersadds Python 3.14 support, these skips can be removed.Additional Fix
Added missing
@pytest.mark.requires_api_keysmarker totest_default_dtype(pre-existing bug unrelated to this PR).