Conversation
Contributor
🛡️ Jit Security Scan Results✅ No security findings were detected in this PR
Security scan by Jit
|
andy-stark-redis
approved these changes
Mar 18, 2026
Contributor
andy-stark-redis
left a comment
There was a problem hiding this comment.
Just a suggestion to simplify the current list with two tab groups (feel free to ignore it) but otherwise LGTM.
| 1. _(Optional)_ Back up the database to minimize the risk of data loss. | ||
|
|
||
| 1. Use [`rladmin`]({{< relref "/operate/rs/references/cli-utilities/rladmin/upgrade" >}}) to upgrade the database. During the upgrade process, the database will restart without losing any data. Use the `preserve_roles` option to keep the database's current state, including primary shard placement, and prevent the cluster from becoming unbalanced. | ||
| 1. Upgrade the database using one of the following methods. During the upgrade process, the database will restart without losing any data. |
Contributor
There was a problem hiding this comment.
Lanugage and links seem fine, but I wonder if you could simplify this by just having the two big multitabs directly after "To upgrade a database..." rather than the current list? It's quite complicated that you have two multitab groups with item 4 separating them (especially when the first tab contains two sequential numbered lists in itself).
You'd have a bit of duplication, adding items 1 to 4 from the outer list into both tabs, but I think it might be worthwhile to give a clearer presentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Documentation-only change that adds UI-based upgrade and version-check instructions alongside existing
rladminguidance; no runtime or API behavior changes.Overview
Adds Cluster Manager UI instructions for upgrading a Redis Software database version, presented alongside the existing
rladminworkflow viamultitabs.Also adds UI-based steps to verify the upgraded database compatibility version, with
rladminverification retained as an alternative.Written by Cursor Bugbot for commit 0fd829f. This will update automatically on new commits. Configure here.