feat: Add random play button to TV interface #2430

y-hbb · 2026-01-20T03:51:04Z

Adds random play functionality to the TV interface, addressing feature parity with the phone layout. Users can now play random content from the Home and Library screens using buttons in the top toolbar.

Changes:

Add random button to Home TV toolbar (between search and account)
Add random button to Library TV toolbar (after search field)
Enable "Random Button" setting visibility for TV users
Add placeholder views in phone layouts for ViewBinding compatibility
Implement dynamic focus chain updates for proper D-pad navigation
Extract shared click handlers to reduce code duplication

Technical details:

Use defensive .toList() copy before .random() to prevent race conditions
Dynamically update nextFocusRightId/nextFocusLeftId when button visibility changes
Reset focus chain when button is hidden to maintain proper TV navigation

Code and commit generated using AI. Let me know if you need me test anything.

Closes #2347

TV
Library:

Home:

Phone
Library:

Home:

fire-light42

Good pull request, however I need you to change some things.

"Use defensive .toList() copy before .random() to prevent race conditions" needs to be changed if you want to properly prevent race conditions.
"Dynamically update nextFocusRightId/nextFocusLeftId when button visibility changes" is useless and all code related to it should be removed. Instead it should be written in the xml navigation as our navigation can handle hidden views.
You forgot about EMULATOR and that views should match exactly, so make the dummy views into ImageViews.

fire-light42 · 2026-01-21T17:59:13Z

app/src/main/java/com/lagradost/cloudstream3/ui/home/HomeFragment.kt

-                if (listHomepageItems.isNotEmpty()) {
-                    activity.loadSearchResult(listHomepageItems.random())
+            val randomClickListener = View.OnClickListener {
+                val items = listHomepageItems.toList()


This is bad, and does not fully solve the problem. If you want to solve it then move it into the page observe, like:

val distinct = mutableListOfResponse.distinctBy { it.url } // <- local variable instead of global homeRandom.isVisible = distinct.isNotEmpty() homeRandom.setOnClickListener { distinct.randomOrNull()?.let { item -> activity.loadSearchResult(item) } }

fire-light42 · 2026-01-21T18:01:35Z

app/src/main/res/layout/fragment_library.xml

            tools:visibility="visible" />

+        <!-- Placeholder for TV layout random button - always hidden on phone -->
+        <View


fire-light42 · 2026-01-21T18:02:10Z

app/src/main/res/layout/fragment_home.xml

        tools:visibility="visible" />
+
+    <!-- Placeholder for TV layout random button - always hidden on phone -->
+    <View


fire-light42 · 2026-01-21T18:03:03Z

app/src/main/java/com/lagradost/cloudstream3/ui/settings/SettingsUI.kt

        val settingsManager = PreferenceManager.getDefaultSharedPreferences(requireContext())

-        getPref(R.string.random_button_key)?.hideOn(EMULATOR or TV)
+        getPref(R.string.random_button_key)?.hideOn(EMULATOR)


Remove entirely.

fire-light42 · 2026-01-21T18:03:24Z

app/src/main/java/com/lagradost/cloudstream3/ui/library/LibraryFragment.kt

-            if (listLibraryItems.isNotEmpty()) {
-                val listLibraryItem = listLibraryItems.random()
+        val randomClickListener = View.OnClickListener {
+            val items = listLibraryItems.toList()


Same issue here.

fire-light42 · 2026-01-21T18:03:57Z

app/src/main/java/com/lagradost/cloudstream3/ui/library/LibraryFragment.kt

+                binding.libraryRandomButtonTv.isVisible = hasItems
+                binding.libraryRandom.isGone = true
+                // Update focus chain: random button is after search field
+                binding.mainSearch.nextFocusRightId = if (hasItems) {


fire-light42 · 2026-01-21T18:04:06Z

app/src/main/java/com/lagradost/cloudstream3/ui/home/HomeFragment.kt

                            homeRandom.isGone = true
+                            homeRandomButtonTv.isGone = true
+                            // Reset focus chain when random button is hidden
+                            if (!isLayout(PHONE)) {


fire-light42 · 2026-01-21T18:04:11Z

app/src/main/java/com/lagradost/cloudstream3/ui/home/HomeFragment.kt

+                                homeRandomButtonTv.isVisible = hasItems
+                                homeRandom.isGone = true
+                                // Update focus chain when random button is visible
+                                if (hasItems) {


fire-light42 · 2026-01-21T18:05:42Z

app/src/main/java/com/lagradost/cloudstream3/ui/library/LibraryFragment.kt

+            binding.libraryRandom.isGone = true
+            binding.libraryRandomButtonTv.isGone = true
+            // Reset focus chain when random button is hidden
+            if (!isLayout(PHONE)) {


y-hbb · 2026-01-22T03:07:40Z

Good pull request, however I need you to change some things.

1. "Use defensive .toList() copy before .random() to prevent race conditions" needs to be changed if you want to properly prevent race conditions.

2. "Dynamically update nextFocusRightId/nextFocusLeftId when button visibility changes" is useless and all code related to it should be removed. Instead it should be written in the xml navigation as our navigation can handle hidden views.

3. You forgot about EMULATOR and that views should match exactly, so make the dummy views into ImageViews.

review comments were fixed. added additional changes to get different random without repeatation.

fire-light42

Do not store it as global variables in the class, that just creates the race condition you wanted to "solve". Furthermore your "random" is overengineered where a simple shuffle and incrementing index should solve it just fine.

Adds random play functionality to the TV interface, addressing feature parity with the phone layout. Users can now play random content from the Home and Library screens using buttons in the top toolbar. Changes: - Add random button to Home TV toolbar (between search and account) - Add random button to Library TV toolbar (after search field) - Enable "Random Button" setting visibility for TV users - Add placeholder views in phone layouts for ViewBinding compatibility - Implement dynamic focus chain updates for proper D-pad navigation - Extract shared click handlers to reduce code duplication Technical details: - Use defensive .toList() copy before .random() to prevent race conditions - Dynamically update nextFocusRightId/nextFocusLeftId when button visibility changes - Reset focus chain when button is hidden to maintain proper TV navigation Code and commit generated using AI

Track previously suggested items to avoid showing the same content repeatedly when using the random button. Resets tracking when content changes or when all items have been shown. includes review comment fixes

Remove shuffle state tracking entirely - just pick a random item on each click using randomOrNull().

y-hbb · 2026-01-22T16:39:49Z

reverted the shuffle changes went back to random function

Simplify visibility and click listener setup by replacing nested if/else with direct boolean assignments. Also removes redundant .toList() call.

fire-light42 requested changes Jan 21, 2026

View reviewed changes

y-hbb force-pushed the random-button-tv branch from db981f8 to 80482b8 Compare January 21, 2026 21:18

y-hbb requested a review from fire-light42 January 21, 2026 21:45

fire-light42 requested changes Jan 22, 2026

View reviewed changes

y-hbb added 3 commits January 22, 2026 11:30

feat: Add no-repeat random selection for home and library

216189a

Track previously suggested items to avoid showing the same content repeatedly when using the random button. Resets tracking when content changes or when all items have been shown. includes review comment fixes

refactor: Simplify random selection to use randomOrNull()

aef2c8d

Remove shuffle state tracking entirely - just pick a random item on each click using randomOrNull().

y-hbb force-pushed the random-button-tv branch from 80482b8 to aef2c8d Compare January 22, 2026 16:31

refactor: Flatten phone/TV branching in random button logic

50c80a2

Simplify visibility and click listener setup by replacing nested if/else with direct boolean assignments. Also removes redundant .toList() call.

y-hbb requested a review from fire-light42 January 22, 2026 17:17

feat: Add random play button to TV interface #2430

Are you sure you want to change the base?

feat: Add random play button to TV interface #2430

Uh oh!

Conversation

y-hbb commented Jan 20, 2026

Uh oh!

fire-light42 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

y-hbb commented Jan 22, 2026

Uh oh!

fire-light42 left a comment

Choose a reason for hiding this comment

Uh oh!

y-hbb commented Jan 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants