Fix logic bugs and add comprehensive type hints#700
Conversation
- Fixed critical bugs in SqliteQueue related to cursor.fetchone() handling and BLOB data loading. - Added safety check in traktMonitor.onNotification to prevent IndexError. - Implemented comprehensive type hints in core library files (utilities.py, kodiUtilities.py, sqlitequeue.py) using the typing module for maximum compatibility. - Fixed shadowing of 'list' built-in and corrected 'any' vs 'Any' usage. - Ensured all 95 existing tests pass. Co-authored-by: razzeee <5943908+razzeee@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Identified and fixed critical logic bugs in the SqliteQueue class and added safety checks to the main service loop. Implemented comprehensive type hints using the typing module to maintain compatibility with older Python 3 versions (pre-3.10) typically found in Kodi environments. Verified changes with the existing test suite (95/95 pass).
PR created automatically by Jules for task 4782863379123261006 started by @razzeee