drm/v3d: Add module parameter to enable MMU error logging #7193
+18
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I'm happy with a module parameter to enable the error logging, but not at the expense of losing even the first error if the parameter is disabled. I would lose the reversion, and make the logging condition |
MMU error messages are useful to help developers quickly identify issues in userspace graphics drivers, but always printing them can swamp the kernel log. Add a module parameter, ``debug_mmu``, to gate MMU error logging. Logging is disabled by default and can be enabled when needed with ``v3d.debug_mmu=1``. Signed-off-by: Maíra Canal <[email protected]>
mairacanal
force-pushed
the
v3d/downstream/mmu-debug
branch
from
e7e7b98 to
338154d
Compare
Contributor
Author
I updated the branch with your suggestion. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, downstream carries a commit that suppresses all but the first MMU error. While this avoids excessive logging, MMU error messages are often valuable for developers during debugging. At the moment, getting this information requires rebuilding the kernel with that commit reverted.
This PR proposes adding a new module parameter (downstream-only) to allow MMU error logging to be enabled on demand, avoiding the need to recompile the kernel.
As an alternative, we could simply revert the commit “drm/v3d: Suppress all but the first MMU error”, since MMU errors are no longer as frequent as they once were.
I'd appreciate to hear your thoughts about the preferred approach.