IMX415 higher link rate support#6807
Draft
6by9 wants to merge 3 commits intoraspberrypi:rpi-6.12.yfrom
Draft
Conversation
Before adding additional modes, sort the list by lane rate as that make most sense. Signed-off-by: Dave Stevenson <[email protected]>
The sensor supports more link rates than the 3 currently supported, although some are only listed as being valid when running with 2 data lanes. Add these additional modes, with setting hblank_min to 0 to denote that it is invalid in that mode. Signed-off-by: Dave Stevenson <[email protected]> --- I'm unable to successfully test 2376Mbit/s mode as it exceeds the hardware specs of the Pi5 CSI2 block. I get an image, but it's got incorrect colours, even with the horizontal timings extended significantly. All the register values follow the datasheet though. I have a suspicion that the modes listed as not permitted in a 2 lanes configuration will work, but I haven't the time to test it at present. Likewise the hmax_min values can almost certainly be decreased as it looks like Sony are just listing values for nice round frame rate values, not the limits. I can't determine the limits easily as Pi5 is limited to a maximum rate of approx 380MPix/s so can't run this sensor above 43fps.
The sensor supports conversion and readout as either 10 or 12 bit data, but the driver only supported 10 bit mode. Add support for 12 bit conversion. Signed-off-by: Dave Stevenson <[email protected]>
Contributor
Author
|
12bit readout mode needs checking that it behaves with all the link frequency options as the datasheet says it is only valid for certain values. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I need to upstream this one, but leaving it here for the time being.