fix: improve O6/O6N setup documentation and fix LFS model cloning#1304
Merged
jack-ma merged 1 commit intoradxa-docs:mainfrom Jan 28, 2026
Merged
fix: improve O6/O6N setup documentation and fix LFS model cloning#1304jack-ma merged 1 commit intoradxa-docs:mainfrom
jack-ma merged 1 commit intoradxa-docs:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Other comments (1)
-
docs/common/orion-common/app-dev/artificial-intelligence/_deeplab-v3.mdx (21-21)
While adding the `-O` flag to specify output filenames is a good improvement, consider adding error checking to the wget commands. If a download fails, wget with `-O` will still create an empty file with the specified name, which could lead to confusion during troubleshooting.
Consider adding something like:
wget -O deeplab_v3.cix https://www.modelscope.cn/models/cix/ai_model_hub_25_Q3/resolve/master/models/ComputeVision/Semantic_Segmentation/onnx_deeplab_v3/deeplab_v3.cix || { echo 'Download failed'; rm -f deeplab_v3.cix; exit 1; }
💡 To request another review, post a new comment with "/windsurf-review".
docs/common/orion-common/app-dev/artificial-intelligence/_whisper-medium.mdx
Outdated
Show resolved
Hide resolved
docs/common/orion-common/app-dev/artificial-intelligence/_scrfd-arcface.mdx
Show resolved
Hide resolved
Contributor
Author
|
/windsurf-review |
Contributor
There was a problem hiding this comment.
Other comments (7)
- docs/common/orion-common/app-dev/artificial-intelligence/_real-esrgan.mdx (20-21) Good improvement adding the `-O` flag to specify output filenames. However, before running the first wget command, you might want to ensure the directory structure exists by adding a `mkdir -p` command. Otherwise, if the directories don't exist yet, the wget command will fail.
-
docs/common/orion-common/app-dev/artificial-intelligence/_scrfd-arcface.mdx (19-23)
These wget commands with explicit output filenames are an improvement, but consider adding `mkdir -p` commands before the download steps to ensure the directory structure exists. For example:
mkdir -p ai_model_hub_25_Q3/models/ComputeVision/Face_Recognition/onnx_scrfd_arcface cd ai_model_hub_25_Q3/models/ComputeVision/Face_Recognition/onnx_scrfd_arcface wget -O arcface.cix https://www.modelscope.cn/models/cix/ai_model_hub_25_Q3/resolve/master/models/ComputeVision/Face_Recognition/onnx_scrfd_arcface/arcface.cix wget -O scrfd.cix https://www.modelscope.cn/models/cix/ai_model_hub_25_Q3/resolve/master/models/ComputeVision/Face_Recognition/onnx_scrfd_arcface/scrfd.cix -
docs/common/orion-common/app-dev/artificial-intelligence/_scrfd-arcface.mdx (47-54)
Consider adding a mkdir command to ensure the directory structure exists:
mkdir -p ai_model_hub_25_Q3/models/ComputeVision/Face_Recognition/onnx_scrfd_arcface/model cd ai_model_hub_25_Q3/models/ComputeVision/Face_Recognition/onnx_scrfd_arcface/model wget -O det_10g.onnx https://www.modelscope.cn/models/cix/ai_model_hub_25_Q3/resolve/master/models/ComputeVision/Face_Recognition/onnx_scrfd_arcface/model/det_10g.onnx wget -O det_2_5g.onnx https://www.modelscope.cn/models/cix/ai_model_hub_25_Q3/resolve/master/models/ComputeVision/Face_Recognition/onnx_scrfd_arcface/model/det_2_5g.onnx wget -O det_500m.onnx https://www.modelscope.cn/models/cix/ai_model_hub_25_Q3/resolve/master/models/ComputeVision/Face_Recognition/onnx_scrfd_arcface/model/det_500m.onnx wget -O w600k_mbf.onnx https://www.modelscope.cn/models/cix/ai_model_hub_25_Q3/resolve/master/models/ComputeVision/Face_Recognition/onnx_scrfd_arcface/model/w600k_mbf.onnx wget -O w600k_r50.onnx https://www.modelscope.cn/models/cix/ai_model_hub_25_Q3/resolve/master/models/ComputeVision/Face_Recognition/onnx_scrfd_arcface/model/w600k_r50.onnx -
docs/common/orion-common/app-dev/artificial-intelligence/_whisper-medium.mdx (21-22)
While specifying output filenames with `-O` is a good practice, the conventional order for wget arguments is to place options like `-O` before the URL. Consider reordering to follow standard practice:
wget -O whisper_medium_multilingual_decoder.cix https://www.modelscope.cn/models/cix/ai_model_hub_25_Q3/resolve/master/models/Audio/Speech_Recognotion/onnx_whisper_medium_multilingual/whisper_medium_multilingual_decoder.cix wget -O whisper_medium_multilingual_encoder.cix https://www.modelscope.cn/models/cix/ai_model_hub_25_Q3/resolve/master/models/Audio/Speech_Recognotion/onnx_whisper_medium_multilingual/whisper_medium_multilingual_encoder.cix -
docs/common/orion-common/app-dev/artificial-intelligence/_whisper-medium.mdx (60-61)
Same suggestion for these wget commands - place the `-O` option before the URL for consistency with standard wget usage:
wget -O whisper_medium_multilingual_decoder.onnx https://www.modelscope.cn/models/cix/ai_model_hub_25_Q3/resolve/master/models/Audio/Speech_Recognotion/onnx_whisper_medium_multilingual/model/whisper_medium_multilingual_decoder.onnx wget -O whisper_medium_multilingual_encoder.onnx https://www.modelscope.cn/models/cix/ai_model_hub_25_Q3/resolve/master/models/Audio/Speech_Recognotion/onnx_whisper_medium_multilingual/model/whisper_medium_multilingual_encoder.onnx - docs/common/orion-common/app-dev/artificial-intelligence/_openpose.mdx (21-21) These wget command changes with the -O flag are helpful for ensuring consistent filenames. Consider adding a brief comment explaining why this change was necessary (e.g., if it resolves issues with LFS model cloning as mentioned in the PR title).
- docs/common/orion-common/app-dev/artificial-intelligence/_ultra-fast-lane-detection-v2.mdx (21-21) Good improvement to the wget commands by explicitly specifying output filenames with `-O`. This helps ensure consistent file naming regardless of server response headers. Consider adding a brief comment explaining why this change was necessary (e.g., if it resolves issues with LFS model cloning mentioned in the PR title).
💡 To request another review, post a new comment with "/windsurf-review".
docs/common/orion-common/app-dev/artificial-intelligence/_deeplab-v3.mdx
Show resolved
Hide resolved
docs/common/orion-common/app-dev/artificial-intelligence/_yolov8s-pose.mdx
Show resolved
Hide resolved
Contributor
Author
|
All done, ready to merge. |
Signed-off-by: Ronin <dengluoning@radxa.com>
xzl01
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
fix: improve O6/O6N setup documentation and fix LFS model cloning